You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/04 15:57:41 UTC

[GitHub] [activemq-website] gemmellr commented on a change in pull request #39: Simpler ActiveMQ Classic Version Release

gemmellr commented on a change in pull request #39:
URL: https://github.com/apache/activemq-website/pull/39#discussion_r570308367



##########
File path: src/_layouts/release.md
##########
@@ -70,15 +67,30 @@ Getting the Source Code
 
 Description|Download Link|Verify
 ---|---|---
-Source Release|[activemq-parent-5.15.13-source-release.zip](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/activemq-parent-5.15.13-source-release.zip.sha512)
+Source Release|[activemq-parent-{{page.version}}-source-release.zip](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/activemq-parent-{{page.version}}-source-release.zip.sha512)

Review comment:
       As earlier comment.

##########
File path: src/_layouts/release.md
##########
@@ -1,23 +1,20 @@
 ---
 layout: default_md
-title: ActiveMQ 5.15.13 Release 
-title-class: page-title-activemq5
-type: activemq5
 ---
 
-[Overview](overview) > [Download](download) > [ActiveMQ 5.15.13 Release](activemq-51513-release)
+[Overview](overview) > [Download](download) > [ActiveMQ {{page.version}} Release](activemq-51513-release)
 
-ActiveMQ 5.15.13 Release
+ActiveMQ {{page.version}} Release
 -----------------------
 
-Apache ActiveMQ 5.15.13 includes several resolved[ issues](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12347002) and bug fixes.
+{{content}}
 
 ### Getting the Binary Distributions
 
 Description|Download Link|_Verify_
 ---|---|---
-Windows Distribution|[apache-activemq-5.15.13-bin.zip](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.zip.sha512)
-Unix/Linux/Cygwin Distribution|[apache-activemq-5.15.13-bin.tar.gz](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/5.15.13/apache-activemq-5.15.13-bin.tar.gz.sha512)
+Windows Distribution|[apache-activemq-{{page.version}}-bin.zip](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.zip.sha512)
+Unix/Linux/Cygwin Distribution|[apache-activemq-{{page.version}}-bin.tar.gz](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz)|[ASC](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.asc), [SHA512](https://archive.apache.org/dist/activemq/{{page.version}}/apache-activemq-{{page.version}}-bin.tar.gz.sha512)

Review comment:
       The archive links should go the download mirrors for the current release(s), not the archive, like the main download page. See the existing 5.16.1 release page this change would replace, for example. Same for the source links below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org