You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/04/01 04:09:06 UTC
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 1, 2016, 2:09 a.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Changes
-------
Rebase.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description
-------
Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Diffs (updated)
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
Thanks,
haosdent huang
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
> On April 1, 2016, 2:53 a.m., fan du wrote:
> > src/linux/perf.cpp, line 354
> > <https://reviews.apache.org/r/43283/diff/2/?file=1321758#file1321758line354>
> >
> > Why did you implement the idea I worked out at https://issues.apache.org/jira/browse/MESOS-4705 by updating your orignal approach
> > at the condition you are in the MESOS-4705 converstaion as well, and you know well I'm working on the same issue?
Hi, @fan.du This is a dependency patch I submit serveral months ago(I think should be ealier before you?).
After look your tickets, it is totally OK for me to don't sumbit this eventually. And because I want to local test [MESOS-5047](https://issues.apache.org/jira/browse/MESOS-5047) in my machine. I have to apply this to avoid it check failed in my machine. I already update the description to clarify this.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review126516
-----------------------------------------------------------
On April 1, 2016, 2:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
>
>
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
>
> Diff: https://reviews.apache.org/r/43283/diff/
>
>
> Testing
> -------
>
> This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by fan du <fa...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/#review126516
-----------------------------------------------------------
src/linux/perf.cpp
<https://reviews.apache.org/r/43283/#comment189528>
Why did you implement the idea I worked out at https://issues.apache.org/jira/browse/MESOS-4705 by updating your orignal approach
at the condition you are in the MESOS-4705 converstaion as well, and you know well I'm working on the same issue?
- fan du
On April 1, 2016, 2:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43283/
> -----------------------------------------------------------
>
> (Updated April 1, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
>
>
> Bugs: MESOS-4655
> https://issues.apache.org/jira/browse/MESOS-4655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
>
> Diff: https://reviews.apache.org/r/43283/diff/
>
>
> Testing
> -------
>
> This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 7, 2016, 10:37 a.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Changes
-------
Rebase.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description
-------
Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Diffs (updated)
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
# Note: This patch would discarded eventually.
Thanks,
haosdent huang
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 4, 2016, 5:23 p.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Changes
-------
Rebase.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description
-------
Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Diffs (updated)
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
# Note: This patch would discarded eventually.
Thanks,
haosdent huang
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 1, 2016, 10:45 a.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Changes
-------
Rebase.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description (updated)
-------
Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Diffs (updated)
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
# Note: This patch would discarded eventually.
Thanks,
haosdent huang
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 1, 2016, 3:06 a.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description
-------
Please skip review this patch @jieyu. This is only used for pass local check in my machine.
Diffs
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing (updated)
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
# Note: This patch would discarded eventually.
Thanks,
haosdent huang
Re: Review Request 43283: Fix
PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43283/
-----------------------------------------------------------
(Updated April 1, 2016, 3:05 a.m.)
Review request for mesos, Ian Downes, Jan Schlicht, and Paul Brett.
Bugs: MESOS-4655
https://issues.apache.org/jira/browse/MESOS-4655
Repository: mesos
Description (updated)
-------
Please skip review this patch @jieyu. This is only used for pass local check in my machine.
Diffs
-----
src/linux/perf.cpp 749e676aaf2ce639dd976f2b23e323300c6114c5
Diff: https://reviews.apache.org/r/43283/diff/
Testing
-------
This also fix similar error in `CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf`.
Thanks,
haosdent huang