You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/08 18:04:34 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11203: fix: revert eTag cache feature for dashboard
codecov-io edited a comment on pull request #11203:
URL: https://github.com/apache/incubator-superset/pull/11203#issuecomment-705733705
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=h1) Report
> Merging [#11203](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b6728d87a04a2e708b772ab4a5457a41d6a16f1c?el=desc) will **decrease** coverage by `4.65%`.
> The diff coverage is `73.07%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11203/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11203 +/- ##
==========================================
- Coverage 65.60% 60.94% -4.66%
==========================================
Files 828 828
Lines 39167 39134 -33
Branches 3589 3589
==========================================
- Hits 25694 23852 -1842
- Misses 13361 15102 +1741
- Partials 112 180 +68
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.14% <73.07%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `55.00% <60.00%> (+4.23%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.64% <72.22%> (-3.63%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `82.68% <100.00%> (+<0.01%)` | :arrow_up: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/incubator-superset/pull/11203/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=footer). Last update [b6728d8...f98e4f9](https://codecov.io/gh/apache/incubator-superset/pull/11203?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org