You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/06/27 18:34:05 UTC
[kudu-CR] KUDU-2420: Support parallel java tests
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10838
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluser uses it’s own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and it’s configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
37 files changed, 206 insertions(+), 312 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/1
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10838
to look at the new patch set (#2).
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
36 files changed, 205 insertions(+), 312 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/2
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@7
PS1, Line 7: KUDU-2420: Support parallel java tests
> I ran the kudu-client tests with `gradle clean test`:
Yeah, that'd be a good idea. You can file a JIRA too if there's too much follow-up work.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@55
PS1, Line 55: // Expose the MiniKuduCluster builder so that subclasses can alter the builder.
: protected static final MiniKuduCluster.MiniKuduClusterBuilder miniClusterBuilder =
: new MiniKuduCluster.MiniKuduClusterBuilder();
:
: // Comma separate describing the master addresses and ports.
: protected static String masterAddresses;
: protected static List<HostAndPort> masterHostPorts;
:
: // We create both versions of the client for ease of use.
: protected static AsyncKuduClient client;
: protected static KuduClient syncClient;
: protected static final Schema basicSchema = getBasicSchema();
: protected static final Schema allTypesSchema = getSchemaWithAllTypes();
> I didn't want to make too many test changes at once. I think a cleanup of t
OK, though the suggestion I'm recommending would mean rewriting all those new static blocks that you added, so another patch would mean some unnecessary churn.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@118
PS1, Line 118: File tempRoot = Files.createTempDirectory("mini-kudu-cluster").toFile();
> Do we need both? I like this functionality here because it handles the clea
There's this code in tool_action_test.cc:
// Normal exit, clean up cluster root.
if (cluster) {
cluster->Shutdown();
WARN_NOT_OK(Env::Default()->DeleteRecursively(cluster->cluster_root()),
"Could not delete cluster root");
}
Doesn't that clean up the cluster state when the cluster is shut down? If so, maybe we don't need this at all?
Anyway, my original concern was just that if you define a test class with 20 tests in it, those 20 cluster root directories are only cleaned up after all 20 tests finish running. It'd be better to delete each one after the test is done, to keep the overall disk space consumption down.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 29 Jun 2018 00:19:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@115
PS5, Line 115: a un
extra space
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@50
PS5, Line 50: protected static final String TABLE_NAME =
Can we get rid of these hacks now, since there shouldn't be any conflicting tables? No need to do it as part of this patch, I'm just curious.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:35:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@7
PS1, Line 7: KUDU-2420: Support parallel java tests
> Without any parallelism, how much slower are Java tests now?
I ran the kudu-client tests with `gradle clean test`:
Before: 7m 18s
After: 9m 34s
With -PmaxParallelForks=#:
4: 5m 17s
8: 4m 23s
Although TestSecurity seams to almost double the time in the test with 8 forks. I ran all the test excluding TestSecurity with 8 threads and it took 2m 28s. It looks like it has some large loops with 5 seconds sleeps. Speeding up those tests could be helpful as a follow up change.
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@10
PS1, Line 10: - Ensures each MiniKuduCluser uses it’s own cluster root.
> MiniKuduCluster
Done
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@10
PS1, Line 10: it’s
> its
Done
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@13
PS1, Line 13: it’s
> its
Done
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@55
PS1, Line 55: // Expose the MiniKuduCluster builder so that subclasses can alter the builder.
: protected static final MiniKuduCluster.MiniKuduClusterBuilder miniClusterBuilder =
: new MiniKuduCluster.MiniKuduClusterBuilder();
:
: // Comma separate describing the master addresses and ports.
: protected static String masterAddresses;
: protected static List<HostAndPort> masterHostPorts;
:
: // We create both versions of the client for ease of use.
: protected static AsyncKuduClient client;
: protected static KuduClient syncClient;
: protected static final Schema basicSchema = getBasicSchema();
: protected static final Schema allTypesSchema = getSchemaWithAllTypes();
> Shouldn't these all be non-static now that they're instantiated per-test?
I didn't want to make too many test changes at once. I think a cleanup of the BaseKuduTest usage in a follow up would be good.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@115
PS1, Line 115: // If a cluster root was not set, create a temp directory to use and clean it up on exit.
> Could you add here whether the temp directory is guaranteed to be unique? I
Yeah it is.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@118
PS1, Line 118: tempRoot.deleteOnExit();
> Would it be possible to delete this after shutdown() too? Does the actual m
Do we need both? I like this functionality here because it handles the clean up in the case that you didn't provide your own root directory, but lets you handle it if you provide your own.
Currently the mini-cluster doesn't do any cleanup.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@518
PS1, Line 518: private String clusterRoot = "";
> Nit: I don't particularly like the convention of using empty string to mean
Done
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@126
PS1, Line 126: // Scan a table to ensure a timestamp is propagated.
: KuduTable table = syncClient.createTable(tableName, basicSchema, getBasicCreateTableOptions());
: syncClient.newScannerBuilder(table).build().nextRows().getNumRows();
: assertTrue(syncClient.hasLastPropagatedTimestamp());
: assertTrue(client.hasLastPropagatedTimestamp());
> What's this doing here? Doesn't seem related to this change.
Previously a timestamp was propagated because the static clients were used in an earlier test and those tests just happened to already perform a scan. This one baffled me for a bit too.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java@36
PS1, Line 36: // Generate a unique table name
: private static final String TABLE_NAME =
: TestRowResult.class.getName() + "-" + System.currentTimeMillis();
> You can also get rid of these sort of things now, because there's no danger
I will consider this for a BaseKuduTest and test cleanup patch.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@50
PS1, Line 50: public class TestSecurity {
> Could we make use of BaseKuduClient in this test?
BaseKuduTest? We can't because the cluster configuration changes for each test and BaseKuduTest doesn't have that type of flexibility. We could make more flexible methods in BaseKuduTest that could be leveraged, but that should be outside this change.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java@29
PS1, Line 29: import java.nio.file.Path;
> Can drop?
Done
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
File java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java@50
PS1, Line 50: testDir.deleteOnExit();
> Is this really necessary if tearDown() deletes it?
I was toying with which method was a better practice for temp files. I will remove it.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 28 Jun 2018 04:04:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@50
PS4, Line 50: protected int numMasters = 3;
: protected int numTabletServers = 3;
> Shouldn't these be constants? i.e. public static final int NUM_MASTERS?
Yeah, I think I left these protected and available to change so that you could override them, but now that we have getMiniClusterBuilder we don't need to expose them.
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java@51
PS4, Line 51: return super.getMiniClusterBuilder()
> Chaining to the superclass' impl makes the overall code flow tougher to fol
That's true now, however there may be some test specific flag in the future that needs to be used. I think inheriting the base functionality is the safest approach.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 29 Jun 2018 18:01:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@50
PS4, Line 50: protected int NUM_MASTERS = 3;
: protected int NUM_TABLET_SERVERS =
> Yeah, I think I left these protected and available to change so that you co
OK, can you make them private static final then too?
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 03 Jul 2018 22:42:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10838
to look at the new patch set (#5).
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
37 files changed, 269 insertions(+), 381 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/5
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10838
to look at the new patch set (#7).
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
39 files changed, 275 insertions(+), 429 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/7
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@50
PS4, Line 50: protected int numMasters = 3;
: protected int numTabletServers = 3;
Shouldn't these be constants? i.e. public static final int NUM_MASTERS?
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java@51
PS4, Line 51: return super.getMiniClusterBuilder()
Chaining to the superclass' impl makes the overall code flow tougher to follow. In this case, the superclass is just setting the number of tservers and masters, which doesn't add much value, so maybe we can just duplicate that here?
Same for the other tests.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 29 Jun 2018 17:53:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/4/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@50
PS4, Line 50: protected int numMasters = 3;
: protected int numTabletServers = 3;
> OK, can you make them private static final then too?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 09 Jul 2018 17:39:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10838
to look at the new patch set (#6).
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
39 files changed, 273 insertions(+), 427 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/6
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/10838/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@50
PS5, Line 50: protected static final String TABLE_NAME =
> Can we get rid of these hacks now, since there shouldn't be any conflicting
I got rid of some of these, but I can go through and do more cleanup.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 10 Jul 2018 15:06:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10838
to look at the new patch set (#3).
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
37 files changed, 266 insertions(+), 364 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/10838/3
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 7
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 09 Jul 2018 18:16:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 1:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@7
PS1, Line 7: KUDU-2420: Support parallel java tests
Without any parallelism, how much slower are Java tests now?
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@10
PS1, Line 10: - Ensures each MiniKuduCluser uses it’s own cluster root.
MiniKuduCluster
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@10
PS1, Line 10: it’s
its
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@13
PS1, Line 13: it’s
its
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@55
PS1, Line 55: // Expose the MiniKuduCluster builder so that subclasses can alter the builder.
: protected static final MiniKuduCluster.MiniKuduClusterBuilder miniClusterBuilder =
: new MiniKuduCluster.MiniKuduClusterBuilder();
:
: // Comma separate describing the master addresses and ports.
: protected static String masterAddresses;
: protected static List<HostAndPort> masterHostPorts;
:
: // We create both versions of the client for ease of use.
: protected static AsyncKuduClient client;
: protected static KuduClient syncClient;
: protected static final Schema basicSchema = getBasicSchema();
: protected static final Schema allTypesSchema = getSchemaWithAllTypes();
Shouldn't these all be non-static now that they're instantiated per-test?
Oh, I see, various tests use static blocks to mutate this state before setUpBase() runs. Perhaps we can do that via an overridden method in BaseKuduTest? For example, you could make miniClusterBuilder private, then provide a no-op version of "void configureCluster(MiniKuduCluster.MiniKuduClusterBuilder foo)" here. Interested tests could override it and make changes to 'foo', then setUpBase() or whatever needs to call configureCluster() before doSetup().
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@115
PS1, Line 115: // If a cluster root was not set, create a temp directory to use and clean it up on exit.
Could you add here whether the temp directory is guaranteed to be unique? I imagine it is (otherwise what's the point), but I wanted to be sure.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@118
PS1, Line 118: tempRoot.deleteOnExit();
Would it be possible to delete this after shutdown() too? Does the actual mini-cluster implementation (the one backed by the control shell) already do that?
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@518
PS1, Line 518: private String clusterRoot = "";
Nit: I don't particularly like the convention of using empty string to mean "create a cluster root for me" when NULL is an already existing "special" value. Can we use NULL instead?
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@126
PS1, Line 126: // Scan a table to ensure a timestamp is propagated.
: KuduTable table = syncClient.createTable(tableName, basicSchema, getBasicCreateTableOptions());
: syncClient.newScannerBuilder(table).build().nextRows().getNumRows();
: assertTrue(syncClient.hasLastPropagatedTimestamp());
: assertTrue(client.hasLastPropagatedTimestamp());
What's this doing here? Doesn't seem related to this change.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java@36
PS1, Line 36: // Generate a unique table name
: private static final String TABLE_NAME =
: TestRowResult.class.getName() + "-" + System.currentTimeMillis();
You can also get rid of these sort of things now, because there's no danger of reusing existing cluster state when retrying.
Could be in a separate patch if you prefer.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@50
PS1, Line 50: public class TestSecurity {
Could we make use of BaseKuduClient in this test?
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java
File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/JarFinder.java@29
PS1, Line 29: import java.nio.file.Path;
Can drop?
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
File java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java@50
PS1, Line 50: testDir.deleteOnExit();
Is this really necessary if tearDown() deletes it?
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 27 Jun 2018 22:47:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10838/1//COMMIT_MSG@7
PS1, Line 7: KUDU-2420: Support parallel java tests
> Yeah, that'd be a good idea. You can file a JIRA too if there's too much fo
I filed KUDU-2489
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
File java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java@55
PS1, Line 55: // Expose the MiniKuduCluster builder so that subclasses can alter the builder.
: protected static final MiniKuduCluster.MiniKuduClusterBuilder miniClusterBuilder =
: new MiniKuduCluster.MiniKuduClusterBuilder();
:
: // Comma separate describing the master addresses and ports.
: protected static String masterAddresses;
: protected static List<HostAndPort> masterHostPorts;
:
: // We create both versions of the client for ease of use.
: protected static AsyncKuduClient client;
: protected static KuduClient syncClient;
: protected static final Schema basicSchema = getBasicSchema();
: protected static final Schema allTypesSchema = getSchemaWithAllTypes();
> OK, though the suggestion I'm recommending would mean rewriting all those n
Fair enough. I will update the patch to remove the static usage.
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:
http://gerrit.cloudera.org:8080/#/c/10838/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@118
PS1, Line 118: tempRoot.deleteOnExit();
> There's this code in tool_action_test.cc:
Interesting. Early on when working on this I though I had cluster state left behind. I tested it again and checked the output directories and they are in fact cleaned up.
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 29 Jun 2018 15:12:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
Patch Set 5:
Test failures should go away if you rebase over current master branch
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 02 Jul 2018 23:35:48 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2420: Support parallel java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10838 )
Change subject: KUDU-2420: Support parallel java tests
......................................................................
KUDU-2420: Support parallel java tests
Makes the changes neccessary to allow for parallel java tests.
- Ensures each MiniKuduCluster uses its own cluster root.
- Replaces usage of @BeforeClass and @AfterClass with
@Before and @After ensuring tests are isolated.
- Fixes test usage of BaseKuduTest and its configurations.
- Replaces usage of BeforeAndAfterAll with BeforeAndAfterEach.
I tested this with `gradle test -PmaxParallelForks=8` and all tests passed locally.
Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Reviewed-on: http://gerrit.cloudera.org:8080/10838
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/gradle/tests.gradle
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITExportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportCsv.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquet.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITImportParquetPreCheck.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITIntegrationTestBigLinkedList.java
M java/kudu-client-tools/src/test/java/org/apache/kudu/mapreduce/tools/ITRowCounter.java
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquire.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthnTokenReacquireOpen.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurityContextRealUser.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestStatistics.java
M java/kudu-flume-sink/src/test/java/org/apache/kudu/flume/sink/AvroKuduOperationsProducerTest.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITInputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITOutputFormatJob.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/TestJarFinder.java
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
M java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/TestContext.scala
39 files changed, 275 insertions(+), 429 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I97c6718b022936a8839f957da0928f54ff6e7371
Gerrit-Change-Number: 10838
Gerrit-PatchSet: 8
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins