You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:07:42 UTC

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #369: Feature add rocketmq consumer topic and broker tag

wu-sheng commented on code in PR #369:
URL: https://github.com/apache/skywalking-java/pull/369#discussion_r1008170243


##########
CHANGES.md:
##########
@@ -22,6 +22,7 @@ Release Notes.
 * Polish up activemq plugin to fix missing broker tag on consumer side
 * Enhance MQ plugin relative tests to check key tags not blank.
 * Add RocketMQ test scenarios for version 4.3 - 4.9. No 4.0 - 4.2 release images for testing.
+* Add RocketMQ consumer span topic and broker tag.

Review Comment:
   ```suggestion
   * Add MQ_TOPIC and MQ_BROKER tags for RocketMQ consumer's span. 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org