[GitHub] [hadoop] steveloughran commented on pull request #5295: YARN-11404. Add junit5 dependency to hadoop-mapreduce-client-app to fix few unit test failure

["steveloughran (via GitHub)" <gi...@apache.org>]

steveloughran commented on PR #5295:
URL: https://github.com/apache/hadoop/pull/5295#issuecomment-1415624965

   couple of belated comments
   
   1. I don't see any need anywhere in the codebase to move to jupiter assertions. It makes backporting harder without offering any tangible benefits.
   If the jupiter team chose to move classes to new packages, well, that's their choice. But if we are going to update test asserts, assertJ is a far better assert framework.
   It's a richer assertion syntax, generates better messages and is already in the 3.3 line -which is why we are using for much of the new tests.
   2, new pom imports should be added to hadoop-project and then referenced, so we can stay on top of the changes.
   
   I'm not going to suggest rolling this back -as it's in, and it was a big piece of work. It's just that in particular the code changes for jupiter assertions wasn't needed and it's potentially counter-productive.
   
   What I would propose is
   * followup PR to move the pom declarations up
   * no new patches to move to jupiter asserts. stay on org.junit or embrace assertJ
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org