You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (Created) (JIRA)" <ji...@apache.org> on 2012/04/03 22:56:29 UTC
[jira] [Created] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Move clusterid and clusterup (shutdown) znodes over to pb
---------------------------------------------------------
Key: HBASE-5707
URL: https://issues.apache.org/jira/browse/HBASE-5707
Project: HBase
Issue Type: Task
Reporter: stack
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5707:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Assignee: stack
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for review Jimmy.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5707.txt, 5707v2.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248888#comment-13248888 ]
Hudson commented on HBASE-5707:
-------------------------------
Integrated in HBase-TRUNK #2722 (See [https://builds.apache.org/job/HBase-TRUNK/2722/])
HBASE-5707 Move clusterid and clusterup (shutdown) znodes over to pb (Revision 1310568)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
* /hbase/trunk/src/main/protobuf/ZooKeeper.proto
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5707.txt, 5707v2.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5707:
-------------------------
Status: Patch Available (was: Open)
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249176#comment-13249176 ]
Hudson commented on HBASE-5707:
-------------------------------
Integrated in HBase-TRUNK-security #161 (See [https://builds.apache.org/job/HBase-TRUNK-security/161/])
HBASE-5707 Move clusterid and clusterup (shutdown) znodes over to pb (Revision 1310568)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
* /hbase/trunk/src/main/protobuf/ZooKeeper.proto
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5707.txt, 5707v2.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245737#comment-13245737 ]
jiraposter@reviews.apache.org commented on HBASE-5707:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4627/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Move two more znodes to serialize their content as pb.
Here are the changes:
{code}
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
Get the clusterid via utility in the ClusterId class rather than
get it directly.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
Serialize and deserialize using new ClusterId pb message.
Include the PBUF preamble on znode content.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
Rename getRootRegionZNodeContent to getZNodeData so it aligns in name
with the other cases where we compose the znode content up in ClusterId
and in ClusterStatusTracker.
M src/main/protobuf/ZooKeeper.proto
Add new messages for ClusterId and ClusterUp
{code}
This addresses bug hbase-5707.
https://issues.apache.org/jira/browse/hbase-5707
Diffs
-----
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java 3fa83e6
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java 61e7367
src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57
src/main/protobuf/ZooKeeper.proto 20f8eb0
Diff: https://reviews.apache.org/r/4627/diff
Testing
-------
Thanks,
Michael
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248625#comment-13248625 ]
jiraposter@reviews.apache.org commented on HBASE-5707:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4627/#review6750
-----------------------------------------------------------
Looks good to me. I prefer to call it startDate instead of startdate. It is up to you.
- Jimmy
On 2012-04-03 21:04:54, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4627/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-03 21:04:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Move two more znodes to serialize their content as pb.
bq.
bq. Here are the changes:
bq.
bq. {code}
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. Get the clusterid via utility in the ClusterId class rather than
bq. get it directly.
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
bq. Serialize and deserialize using new ClusterId pb message.
bq. Include the PBUF preamble on znode content.
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
bq. Rename getRootRegionZNodeContent to getZNodeData so it aligns in name
bq. with the other cases where we compose the znode content up in ClusterId
bq. and in ClusterStatusTracker.
bq. M src/main/protobuf/ZooKeeper.proto
bq. Add new messages for ClusterId and ClusterUp
bq. {code}
bq.
bq.
bq. This addresses bug hbase-5707.
bq. https://issues.apache.org/jira/browse/hbase-5707
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969
bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java 3fa83e6
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java 61e7367
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57
bq. src/main/protobuf/ZooKeeper.proto 20f8eb0
bq.
bq. Diff: https://reviews.apache.org/r/4627/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5707:
-------------------------
Attachment: 5707v2.txt
Change startdate to startDate as per Jimmy suggestion.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245844#comment-13245844 ]
Hadoop QA commented on HBASE-5707:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521219/5707.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1379//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1379//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1379//console
This message is automatically generated.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248679#comment-13248679 ]
Hadoop QA commented on HBASE-5707:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521723/5707v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause mvn compile goal to fail.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1437//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1437//console
This message is automatically generated.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5707:
-------------------------
Attachment: 5707v2.txt
Version that compiles.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt, 5707v2.txt, 5707v2.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5707) Move clusterid and clusterup
(shutdown) znodes over to pb
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5707:
-------------------------
Attachment: 5707.txt
{code}
M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
Get the clusterid via utility in the ClusterId class rather than
get it directly.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
Serialize and deserialize using new ClusterId pb message.
Include the PBUF preamble on znode content.
M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
Rename getRootRegionZNodeContent to getZNodeData so it aligns in name
with the other cases where we compose the znode content up in ClusterId
and in ClusterStatusTracker.
M src/main/protobuf/ZooKeeper.proto
Add new messages for ClusterId and ClusterUp
{code}
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira