[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #7076: Upgrade t-digest to 3.3

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #7076:
URL: https://github.com/apache/incubator-pinot/pull/7076#discussion_r654982740



##########
File path: pinot-core/src/test/java/org/apache/pinot/core/startree/v2/PreAggregatedPercentileTDigestStarTreeV2Test.java
##########
@@ -30,7 +30,9 @@
 
 public class PreAggregatedPercentileTDigestStarTreeV2Test extends BaseStarTreeV2Test<Object, TDigest> {
   // Use non-default compression
-  private static final double COMPRESSION = 50;
+  private static final double COMPRESSION = 200;

Review comment:
       Does this mean we need to change the compression factor to 200 to be within 5% error? IIRC, we are using 100? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org