You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/03 20:51:15 UTC
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12924
to review the following change.
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
dist_test.py: support --collect-tmpdir in Java tests
KUDU-2761 means this isn't useful yet, but it will be when that's fixed.
Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
---
M build-support/dist_test.py
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
2 files changed, 36 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/12924/1
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12924 )
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
dist_test.py: support --collect-tmpdir in Java tests
KUDU-2761 means this isn't useful yet, but it will be when that's fixed.
I also snuck in a fix for a typo in RetryRule.
Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Reviewed-on: http://gerrit.cloudera.org:8080/12924
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M build-support/dist_test.py
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
3 files changed, 37 insertions(+), 14 deletions(-)
Approvals:
Adar Dembo: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12924
to look at the new patch set (#2).
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
dist_test.py: support --collect-tmpdir in Java tests
KUDU-2761 means this isn't useful yet, but it will be when that's fixed.
I also snuck in a fix for a typo in RetryRule.
Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
---
M build-support/dist_test.py
M java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/RetryRule.java
3 files changed, 37 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/12924/2
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12924 )
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 )
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Wed, 03 Apr 2019 22:09:28 +0000
Gerrit-HasComments: No
[kudu-CR] dist test.py: support --collect-tmpdir in Java tests
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12924 )
Change subject: dist_test.py: support --collect-tmpdir in Java tests
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, more flakes.
--
To view, visit http://gerrit.cloudera.org:8080/12924
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8bb699c78b3b1ea64c92d53996aa4e5c8cfbe0e
Gerrit-Change-Number: 12924
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 03 Apr 2019 22:08:42 +0000
Gerrit-HasComments: No