You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/12 08:23:35 UTC
[GitHub] [rocketmq] echooymxq opened a new issue, #5291: Optimise the HandshakeHandler
echooymxq opened a new issue, #5291:
URL: https://github.com/apache/rocketmq/issues/5291
1. Remove the mark and reset bytebuf readerIndex code.
https://github.com/apache/rocketmq/blob/8d10c9601d137be397d17003634cceb89c949a69/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java#L455-L459
It is unnecessary, because`ByteBuf#getByte` not modify readerIndex or writerIndex.
2. When the handshake ssl configuration has some problem and ctx closed, it shouldn't fire the message to next handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui closed issue #5291: Optimise the HandshakeHandler
Posted by GitBox <gi...@apache.org>.
lizhanhui closed issue #5291: Optimise the HandshakeHandler
URL: https://github.com/apache/rocketmq/issues/5291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org