[GitHub] [fineract] galovics commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module

[GitBox <gi...@apache.org>]

galovics commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r969643899


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
             recurrenceStartDate = null;
         }
 
-        return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
-                submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
-                recurrenceStartDate);
+        return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)

Review Comment:
   I think this is missing:
   this.status = EmailCampaignStatus.PENDING.getValue();



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org