[jira] [Commented] (SOLR-13939) Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort

["Erick Erickson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156364#comment-17156364 ] 

Erick Erickson commented on SOLR-13939:
---------------------------------------

I'm starting to go through this now. There are three categories, and I'll treat them as separate commits/pushes rather than ask people to wade through a mass of changes, I'll try to group them either logically or in bite-sized chunks.

1> rote stuff. This includes SuppressWarnings, a neat thing Mark found with Collections.emptyList() rather than Collections.EMPTY_LIST not generating unchecked warnings, very minor code cleanups and the like. I'll push this as soon as it passes gw check, ant precommit and ant test..

Some of the changes here have to do with suppressing deprecation warnings, and I'm not including them. First, there aren't very many and second there's a much larger effort under way that should incorporate them all. There are a few annotations that have been added as well as some documentation about what to use instead that I _am_ including.

2> There are about 32 changed files that look to be about thread leaks that we can't do anything about. Many having to do with HDFS but some others scattered about. I'll put them all in a single PR after <1> is done and ask for comments.

3> everything else. There are only about 4 other files that have changed, and all I've done so far is put them on the back burner. When I get to dealing with these, I'll look more carefully and report either here or via a PR.


> Extract any non-gradle related patches (deprecations, URL fixes, etc.) from gradle effort
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-13939
>                 URL: https://issues.apache.org/jira/browse/SOLR-13939
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-13939.patch, eoe_merged.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org