[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1502: Feat: Implement ZUNION

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1502:
URL: https://github.com/apache/incubator-kvrocks/pull/1502#discussion_r1234754184


##########
src/types/redis_zset.cc:
##########
@@ -744,16 +754,15 @@ rocksdb::Status ZSet::UnionStore(const Slice &dst, const std::vector<KeyWeight>
       }
     }
   }
-  if (!dst_zset.empty()) {
-    std::vector<MemberScore> mscores;
-    mscores.reserve(dst_zset.size());
+  auto compare_score = [](const MemberScore &score1, const MemberScore &score2) { return score1.score < score2.score; };

Review Comment:
   > @uds5501 If I understand correctly, the initial order of how members are stored is already lexicographically sorted and retrieved in that order. @git-hulk Fix my thought if it is incorrect.
   
   Yes, that's right.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org