You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Marshall Pierce (JIRA)" <ji...@apache.org> on 2011/07/01 06:07:28 UTC

[jira] [Commented] (CASSANDRA-803) remove PropertyConfigurator from CassandraDaemon

    [ https://issues.apache.org/jira/browse/CASSANDRA-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058209#comment-13058209 ] 

Marshall Pierce commented on CASSANDRA-803:
-------------------------------------------

It's a shame to add a hard dep on log4j for this, especially when both dynamically reloading configs and the thing that caused the use of PropertyConfigurator to get back in (CASSANDRA-1525, configuring via JMX) are already handled natively by Logback without any in-code configuration. (http://logback.qos.ch/manual/configuration.html#autoScan and http://logback.qos.ch/manual/jmxConfig.html).

I'm happy to contribute a patch. What about simply making that static initializer block short-circuit if log4j isn't there? It's kind of hackish but it does the job. I'd be happy to rip out all the log4j specific stuff and replace it with slf4j if that patch would be used.

> remove PropertyConfigurator from CassandraDaemon
> ------------------------------------------------
>
>                 Key: CASSANDRA-803
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-803
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6
>            Reporter: Jesse McConnell
>
> In order for users to make use of the EmbeddedCassandraService for unit testing they need to have a dependency declared on log4j.  
> It would be nice if we could use the log4j-over-slf4j artifact to bridge this requirement for those of us using slf4j.  
> http://www.slf4j.org/legacy.html#log4j-over-slf4j
> Currently it errors with the direct usage of the PropertyConfigurator in o.a.c.thrift.CassandraDaemon.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira