[jira] [Comment Edited] (OAK-3789) Index definition for properties should allow "not creating any fields" for that property

["Chetan Mehrotra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059651#comment-15059651 ] 

Chetan Mehrotra edited comment on OAK-3789 at 12/16/15 7:42 AM:
----------------------------------------------------------------

Again like OAK-3576 bit late for review but still ;)

I checked the logic and was thinking that same effect can be achieved now also by just setting {{index}} to false on the given property definition node. The presence of property definition would trigger {{propertyChanged}} call for such a property to lead to {{propertiesChanged}} set to true. And this would trigger the call to {{makeDocument}} and that would enable call to the {{IndexFieldProvider}}

Testcase {{skipDefaultIndexing}} passes if I set {{index}} to false

Thoughts?


was (Author: chetanm):
Again like OAK-3576 bit late for review but still ;)

I checked the logic and was thinking that same effect can be achieved now also by just setting {{index}} to false on the given property definition node. The presence of property definition would trigger {{propertyChanged}} call for such a property to lead to {{propertiesChanged}} set to true. And this would trigger the call to {{makeDocument}} and that would enable call to the {{IndexFieldProvider}}

Thoughts?

> Index definition for properties should allow "not creating any fields" for that property
> ----------------------------------------------------------------------------------------
>
>                 Key: OAK-3789
>                 URL: https://issues.apache.org/jira/browse/OAK-3789
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Minor
>             Fix For: 1.3.13
>
>
> For OAK-3576, we want to have index definitions for properties which are relevant *only* for a registered callback. Such properties, when changes, shouldn't create any fields. All other indexing behavior (while indexing or while creating query plans etc) should remain the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)