You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2018/10/18 20:34:41 UTC
hive git commit: HIVE-20756 : Disable SARG leaf creation for date
column until ORC-135 (Chiran Ravani,
reviewed by Sergey Shelukhin and Prasanth Jayachandran)
Repository: hive
Updated Branches:
refs/heads/branch-1 db72a865c -> 7fecb6f56
HIVE-20756 : Disable SARG leaf creation for date column until ORC-135 (Chiran Ravani, reviewed by Sergey Shelukhin and Prasanth Jayachandran)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/7fecb6f5
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/7fecb6f5
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/7fecb6f5
Branch: refs/heads/branch-1
Commit: 7fecb6f56a610ab28fa6bd84944908d029a86c6f
Parents: db72a86
Author: Chiran Ravani <cr...@hortonworks.com>
Authored: Thu Oct 18 13:34:46 2018 -0700
Committer: sergey <se...@apache.org>
Committed: Thu Oct 18 13:34:46 2018 -0700
----------------------------------------------------------------------
.../org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java | 7 +++++++
1 file changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/7fecb6f5/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
----------------------------------------------------------------------
diff --git a/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java b/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
index a21a298..f7948d5 100644
--- a/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
+++ b/ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
@@ -384,6 +384,13 @@ class RecordReaderImpl implements RecordReader {
return TruthValue.YES_NO_NULL;
}
+ // TODO: Enabling PPD for timestamp requires ORC-101 and ORC-135
+ if (min != null && min instanceof Date) {
+ LOG.warn("Not using predication pushdown on " + predicate.getColumnName() + " because it doesn't " +
+ "include ORC-135.");
+ return TruthValue.YES_NO_NULL;
+ }
+
TruthValue result;
Object baseObj = predicate.getLiteral();
try {