You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/30 11:49:54 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1026: MINIFICPP-1524 Add shellcheck integration for linting shell scripts

lordgamez commented on a change in pull request #1026:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1026#discussion_r604024246



##########
File path: bstrp_functions.sh
##########
@@ -75,30 +75,31 @@ set_incompatible_with(){
 }
 
 print_multi_option_status(){
-  feature="$1"
   feature_status=${!1}
   declare -a VAR_OPTS=()
 
-  declare VAR_OPTS=$1_OPTIONS[@]
-  VAR_OPTS=$1_OPTIONS[@]
+  declare VAR_OPTS=("$1_OPTIONS[@]")
+  VAR_OPTS=("$1_OPTIONS[@]")
 
   for option in "${!VAR_OPTS}" ; do
     if [ "${option}" = "$feature_status" ]; then
+      # shellcheck disable=SC2059
     	printf "${RED}"
     fi
+    # shellcheck disable=SC2059
     printf "${option}"
+    # shellcheck disable=SC2059
     printf "${NO_COLOR} "

Review comment:
       Great suggestion! Updated in 4650e8b54fcab4ef1c6a709a2cfdc21eadb2903b




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org