[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1135: DISPATCH-2039 WIP Instead of poison, set zero capacity of the pool and let it degenerate into immediate malloc/free

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1135:
URL: https://github.com/apache/qpid-dispatch/pull/1135#discussion_r615353187



##########
File path: src/alloc_pool.c
##########
@@ -280,11 +282,12 @@ static void qd_alloc_init(qd_alloc_type_desc_t *desc)
         if (desc->additional_size)
             desc->total_size += *desc->additional_size;
 
-        if (desc->config == 0)
-            desc->config = desc->total_size > BIG_THRESHOLD ?
-                &qd_alloc_default_config_big : &qd_alloc_default_config_small;
-
-        assert (desc->config->local_free_list_max >= desc->config->transfer_batch_size);
+        desc->config = &qd_alloc_default_config_asan;
+//        if (desc->config == 0)
+//            desc->config = desc->total_size > BIG_THRESHOLD ?
+//                &qd_alloc_default_config_big : &qd_alloc_default_config_small;
+//
+//        assert (desc->config->local_free_list_max >= desc->config->transfer_batch_size);

Review comment:
       I think the assert is wrong; `local_free_list_max == 0` and `transfer_batch_size == 1` works just fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org