[jira] [Commented] (DISPATCH-1671) An unused import?

["Jiri Daněk (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DISPATCH-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406384#comment-17406384 ] 

Jiri Daněk commented on DISPATCH-1671:
--------------------------------------

These imports are not used by the Python code directly, but they are used to infer the presence of Qpid Cpp broker on the machine, and to run systemtests that check integration with the broker. These tests, due to the arcane way in which they are unskipped, are not running in CI and I suspect that committers don't run them either.

https://github.com/apache/qpid-dispatch/blob/main/tests/system_tests_broker.py#L34

My preferred solution to test broker integration would be to use ActiveMQ Artemis, probably either with Testcontainers (https://www.testcontainers.org/) or with some automated way to download the broker and run it listening on randomly assigned free port numbers.

Qpid Cpp tests feel less useful to me, but there could be value in possibly moving them onto Testcontainers too, mainly because the tests are already written in some form that used to pass at some point.

> An unused import?
> -----------------
>
>                 Key: DISPATCH-1671
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-1671
>             Project: Qpid Dispatch
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.15.0
>            Reporter: Justin Ross
>            Priority: Minor
>
> https://github.com/apache/qpid-dispatch/blob/f62c85f40bbd77776d0bddea66938fe9319deaa5/tests/system_test.py#L83
> The system test code tries to import python qpid_messaging.  I don't think it uses it.  But the presence of the import triggers a failure on Fedora 31 for me, because if qpid_messaging is present, it attempts to use a swig API that has gone away in swig 4.0.
> I think the right thing is to remove the qpid_messaging import.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org