You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/10/22 23:19:48 UTC
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1294
[FLINK-1982] [record-api] Remove dependencies on Record API from flink-runtime tests
Rename Match*Test to Join*Test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink runtimeTestsRecord
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1294.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1294
----
commit 6367ad7e05eb81f1bf719beda0eeb972864ee568
Author: Fabian Hueske <fh...@apache.org>
Date: 2015-10-22T19:10:41Z
[FLINK-1982] [record-api] Remove dependencies on Record API from flink-runtime tests
Rename Match*Test to Join*Test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1294#discussion_r42808744
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java ---
@@ -39,7 +38,7 @@
import org.junit.Test;
@SuppressWarnings("deprecation")
--- End diff --
this suppression can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1294#issuecomment-150543514
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1294#issuecomment-150521085
Thanks @hsaputra
I renamed the class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1294#discussion_r42809588
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java ---
@@ -39,7 +38,7 @@
import org.junit.Test;
@SuppressWarnings("deprecation")
--- End diff --
Good catch, thanks!
Will check the other classes as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/1294#discussion_r42818462
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/MapTaskTest.java ---
@@ -38,8 +37,7 @@
import org.junit.Assert;
import org.junit.Test;
-@SuppressWarnings("deprecation")
-public class MapTaskTest extends DriverTestBase<GenericCollectorMap<Record, Record>> {
+public class MapTaskTest extends DriverTestBase<FlatMapFunction<Record, Record>> {
--- End diff --
Small nit: should probably rename this to ``FlatMapTaskTest`` since now it is actually using ``flatMap`` function instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1982] [record-api] Remove dependencies ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1294#issuecomment-150375992
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---