You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mikhail Loenko (JIRA)" <ji...@apache.org> on 2007/09/19 06:28:43 UTC
[jira] Created: (HARMONY-4818) first step towards Java6 BC
verification: splitting existing code
first step towards Java6 BC verification: splitting existing code
-----------------------------------------------------------------
Key: HARMONY-4818
URL: https://issues.apache.org/jira/browse/HARMONY-4818
Project: Harmony
Issue Type: New Feature
Components: DRLVM
Reporter: Mikhail Loenko
Assignee: Mikhail Loenko
Attachments: verifier-refactoring.zip
as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
mostly by removing some code.
Since we all don't want code duplication, it makes sense to split current verifier to
common part that will be used by both Java5 and Java6 verifiers and Java5-specific
part.
I've made such a separation and here is the code for review.
The modifications made are mostly splitting the files and moving unmodified pieces
of code around. So, I submitted 'code' rather then 'patch'.
_base suffix or no suffix means that it's a base part, common for both verifiers
_x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
_5 suffix means pure Java5 code
I've created a new namespace for _5 code, so that later I'll create different
Java6-specific types with the same names in Java6-specific namespace
Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4818) first step towards Java6 BC
verification: splitting existing code
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Loenko updated HARMONY-4818:
------------------------------------
Attachment: verifier-refactoring.zip
> first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------
>
> Key: HARMONY-4818
> URL: https://issues.apache.org/jira/browse/HARMONY-4818
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Loenko
> Assignee: Mikhail Loenko
> Attachments: verifier-refactoring.zip
>
>
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4818) [drlvm][verifier] first step towards
Java6 BC verification: splitting existing code
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-4818:
---------------------------------------
Summary: [drlvm][verifier] first step towards Java6 BC verification: splitting existing code (was: first step towards Java6 BC verification: splitting existing code)
> [drlvm][verifier] first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-4818
> URL: https://issues.apache.org/jira/browse/HARMONY-4818
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Loenko
> Assignee: Mikhail Loenko
> Attachments: verifier-refactoring.zip, verifier-refactoring2.zip
>
>
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-4818) [drlvm][verifier] first step
towards Java6 BC verification: splitting existing code
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Loenko resolved HARMONY-4818.
-------------------------------------
Resolution: Fixed
Fix Version/s: 5.0M4
integrated in r584118
> [drlvm][verifier] first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------------------------
>
> Key: HARMONY-4818
> URL: https://issues.apache.org/jira/browse/HARMONY-4818
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Loenko
> Assignee: Mikhail Loenko
> Fix For: 5.0M4
>
> Attachments: verifier-refactoring.zip, verifier-refactoring2.zip
>
>
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-4818) first step towards Java6 BC
verification: splitting existing code
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Loenko updated HARMONY-4818:
------------------------------------
Attachment: verifier-refactoring2.zip
now with Java6 verifier imlemented - as a proof of concept that separation in the first variant was right (well, with some minor mods :-)
If you didn't look at the first variant please start with the second one.
> first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------
>
> Key: HARMONY-4818
> URL: https://issues.apache.org/jira/browse/HARMONY-4818
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Loenko
> Assignee: Mikhail Loenko
> Attachments: verifier-refactoring.zip, verifier-refactoring2.zip
>
>
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-4818) first step towards Java6 BC
verification: splitting existing code
Posted by "Pavel Pervov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-4818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533078 ]
Pavel Pervov commented on HARMONY-4818:
---------------------------------------
Re "verifier-refactoring2/patch.txt". We, probably, should throw InternalError rather than ClassFormatError if we were unable to cfs.skip(-6). Other, than that patch looks ok to me.
> first step towards Java6 BC verification: splitting existing code
> -----------------------------------------------------------------
>
> Key: HARMONY-4818
> URL: https://issues.apache.org/jira/browse/HARMONY-4818
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Mikhail Loenko
> Assignee: Mikhail Loenko
> Attachments: verifier-refactoring.zip, verifier-refactoring2.zip
>
>
> as Alexei F noted somewhere Java6 verifier might be obtained from Java5 verifier
> mostly by removing some code.
> Since we all don't want code duplication, it makes sense to split current verifier to
> common part that will be used by both Java5 and Java6 verifiers and Java5-specific
> part.
> I've made such a separation and here is the code for review.
> The modifications made are mostly splitting the files and moving unmodified pieces
> of code around. So, I submitted 'code' rather then 'patch'.
> _base suffix or no suffix means that it's a base part, common for both verifiers
> _x suffix means that the same code operates with different types, it's written with templates. There are 2000+ lines of such a code.
> _5 suffix means pure Java5 code
> I've created a new namespace for _5 code, so that later I'll create different
> Java6-specific types with the same names in Java6-specific namespace
> Please review the code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.