[jira] [Commented] (ZOOKEEPER-847) Missing acl check in zookeeper create

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093568#comment-13093568 ] 

Hadoop QA commented on ZOOKEEPER-847:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12492215/ZOOKEEPER-847.patch
  against trunk revision 1163106.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/480//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/480//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/480//console

This message is automatically generated.

> Missing acl check in zookeeper create
> -------------------------------------
>
>                 Key: ZOOKEEPER-847
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.1, 3.3.2, 3.3.3
>            Reporter: Patrick Datko
>            Assignee: Laxman
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-847.patch
>
>
> I watched the source of the zookeeper class and I missed an acl check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no
> check whether the acl is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug.
> The following code is missing:
>         if (acl != null && acl.size() == 0) {
>             throw new KeeperException.InvalidACLException();
>         }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira