[GitHub] [incubator-tvm] tqchen commented on issue #4570: [relay] Relay annotation and partitioning for external compilers

[GitBox <gi...@apache.org>]

tqchen commented on issue #4570: [relay] Relay annotation and partitioning for external compilers
URL: https://github.com/apache/incubator-tvm/pull/4570#issuecomment-570856097
 
 
   It would be great to think a bit more about the API. Personally, I don't like the fact that we are adding new build functions (build_extern_compiler). We should advocate the pipeline API more and avoid the general interface.
   
   Given that this is not our final form, I would suggest we only keep the pipeline API. e.g.
   
   ```python
   mod = relay.transform.AnnotateExternCompiler("dnnl")(mod)
   ```
   
   Similarly, the term register_annotate_compiler seems to be quite arbitrary. Is it mainly built for dnnl? should it have a dnnl namespace instead, should we just make use of set_attr for now?
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services