[GitHub] [dubbo] chickenlj commented on a diff in pull request #11975: Performance Optimization

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #11975:
URL: https://github.com/apache/dubbo/pull/11975#discussion_r1162417495


##########
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/FrameworkServiceRepository.java:
##########
@@ -83,18 +78,10 @@ public List<ProviderModel> lookupExportedServicesWithoutGroup(String key) {
         return providersWithoutGroup.get(key);
     }
 
-    public void registerProviderUrl(URL url) {
-        ConcurrentHashMapUtils.computeIfAbsent(providerUrlsWithoutGroup, keyWithoutGroup(url.getServiceKey()), (k) -> new CopyOnWriteArrayList<>()).add(url);
-    }
-
     public ProviderModel lookupExportedService(String serviceKey) {
         return providers.get(serviceKey);
     }
 
-    public List<URL> lookupRegisteredProviderUrlsWithoutGroup(String key) {
-        return providerUrlsWithoutGroup.get(key);
-    }
-

Review Comment:
   Why are all these public APIs removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org