You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2014/12/15 08:07:04 UTC
wicket git commit: Java 8 TODOs
Repository: wicket
Updated Branches:
refs/heads/master b6f3a605d -> 89f04bd50
Java 8 TODOs
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/89f04bd5
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/89f04bd5
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/89f04bd5
Branch: refs/heads/master
Commit: 89f04bd50c84f9ebb118cdf3deb5962db3c4d369
Parents: b6f3a60
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon Dec 15 09:06:29 2014 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon Dec 15 09:06:29 2014 +0200
----------------------------------------------------------------------
.../main/java/org/apache/wicket/util/IProvider.java | 7 ++-----
.../java/org/apache/wicket/util/crypt/Base64.java | 5 ++---
.../java/org/apache/wicket/util/string/Strings.java | 14 ++++++--------
3 files changed, 10 insertions(+), 16 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/89f04bd5/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
index 8bc0c7d..ea2a70a 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/IProvider.java
@@ -22,6 +22,8 @@ package org.apache.wicket.util;
* @author igor.vaynberg
* @param <T>
*/
+// TODO Wicket 8: consider to deprecate this interface in Wicket 7 and replace it with standard
+// Java 8 {@code java.util.function.Supplier<T>} which is virtually identical.
public interface IProvider<T>
{
/**
@@ -30,9 +32,4 @@ public interface IProvider<T>
* @return instance of type {@code T}
*/
T get();
-
- /**
- * TODO Wicket 8: consider to deprecate this interface in Wicket 7 and replace it with standard
- * Java 8 {@code java.util.function.Supplier<T>} which is virtually identical.
- * */
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/89f04bd5/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
index 4d2388a..cf5cbb0 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/crypt/Base64.java
@@ -39,14 +39,13 @@ import java.math.BigInteger;
*
* @since 1.2
*/
+// TODO Wicket 8: consider to deprecate this class in Wicket 7 and replace it with standard Java 8 {@code java.util.Base64}
public class Base64
{
- //* TODO Wicket 8: consider to deprecate this class in Wicket 7 and replace it with standard Java 8 {@code java.util.Base64}
-
private static final int DEFAULT_BUFFER_RESIZE_FACTOR = 2;
private static final int DEFAULT_BUFFER_SIZE = 8192;
-
+
/**
* Chunk size per RFC 2045 section 6.8.
*
http://git-wip-us.apache.org/repos/asf/wicket/blob/89f04bd5/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
index 103f6b0..49119f7 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java
@@ -51,13 +51,6 @@ import org.apache.wicket.util.lang.Args;
*/
public final class Strings
{
- /**
- * TODO Wicket 8: consider to deprecate methods {@code join} in Wicket 7 and replace it with standard
- * Java 8 methods {@code String#join(CharSequence delimiter, CharSequence... elements)}
- * and {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)}
- *
- * */
-
/**
* The line separator for the current platform.
*/
@@ -640,6 +633,9 @@ public final class Strings
* @param fragments
* @return combined fragments
*/
+ // TODO Wicket 8: consider to deprecate methods {@code join} in Wicket 7 and replace it with standard
+ // Java 8 methods {@code String#join(CharSequence delimiter, CharSequence... elements)}
+ // and {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)}
public static String join(final String separator, final List<String> fragments)
{
if (fragments == null)
@@ -649,7 +645,6 @@ public final class Strings
return join(separator, fragments.toArray(new String[fragments.size()]));
}
-
/**
* Joins string fragments using the specified separator
*
@@ -657,6 +652,9 @@ public final class Strings
* @param fragments
* @return combined fragments
*/
+ // TODO Wicket 8: consider to deprecate methods {@code join} in Wicket 7 and replace it with standard
+ // Java 8 methods {@code String#join(CharSequence delimiter, CharSequence... elements)}
+ // and {@code String#join(CharSequence delimiter, Iterable<? extends CharSequence> elements)}
public static String join(final String separator, final String... fragments)
{
if ((fragments == null) || (fragments.length < 1))