[GitHub] [kylin] yanghua commented on issue #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not

[GitBox <gi...@apache.org>]

yanghua commented on issue #509: KYLIN-3864 Provide a function to judge whether the os type is Mac os x or not
URL: https://github.com/apache/kylin/pull/509#issuecomment-473759267
 
 
   Hi @shaofengshi  Now, In kylin project, there are many places where the code would check the os type is **Darwin** (Mac os X) such as `download-spark.sh`, `download-flink.sh`, `tool-wrapper.sh`. And there are some places where Kylin is not compatible with Mac os X (it does not check the os type), it caused some errors, such as [KYLIN-3756](https://issues.apache.org/jira/browse/KYLIN-3756) and [KYLIN-3757](https://issues.apache.org/jira/browse/KYLIN-3757). This util method provides a general function to verify whether the current os type is Mac os X or not.
   
   By providing this function, we can do generic checking for the different `like-UNIX` os, and fix those compatible issues existing in the shell script.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services