You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2011/03/21 15:56:11 UTC

[jira] [Created] (NET-384) KeyManagerUtils - the KeyManager is not efficient

KeyManagerUtils - the KeyManager is not efficient
-------------------------------------------------

                 Key: NET-384
                 URL: https://issues.apache.org/jira/browse/NET-384
             Project: Commons Net
          Issue Type: Improvement
            Reporter: Sebb


The clientKey manager performs some of the work that could be done as part of creating the key store.

Since the manager is potentially called many times, it would be better to move the setup processing to the creation of the keystore.

This requires creating a sub-class of KeyStore, which might as well be a private class created by createClientKeyManager()

The calling sequence would then be:

{code}
KeyManager km = KeyManagerUtils.createClientKeyManager(
    "JKS", "/path/to/privatekeystore.jks", "storepassword", "privatekeyalias", "keypassword");
FTPSClient cl = new FTPSClient();
cl.setKeyManager(km);
{code}

For JKS stores with a single entry and keypassword == storepassword this would simplify to:

{code}
KeyManager km = KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks", "storepassword");
FTPSClient cl = new FTPSClient();
cl.setKeyManager(km);
{code}


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (NET-384) KeyManagerUtils - the KeyManager is not efficient

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-384.
----------------------

    Resolution: Fixed

> KeyManagerUtils - the KeyManager is not efficient
> -------------------------------------------------
>
>                 Key: NET-384
>                 URL: https://issues.apache.org/jira/browse/NET-384
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>
> The clientKey manager performs some of the work that could be done as part of creating the key store.
> Since the manager is potentially called many times, it would be better to move the setup processing to the creation of the keystore.
> This requires creating a sub-class of KeyStore, which might as well be a private class created by createClientKeyManager()
> The calling sequence would then be:
> {code}
> KeyManager km = KeyManagerUtils.createClientKeyManager(
>     "JKS", "/path/to/privatekeystore.jks", "storepassword", "privatekeyalias", "keypassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}
> For JKS stores with a single entry and keypassword == storepassword this would simplify to:
> {code}
> KeyManager km = KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks", "storepassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (NET-384) KeyManagerUtils - the KeyManager is not efficient

Posted by "Sebb (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/NET-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-384:
---------------------

    Fix Version/s: 3.0

> KeyManagerUtils - the KeyManager is not efficient
> -------------------------------------------------
>
>                 Key: NET-384
>                 URL: https://issues.apache.org/jira/browse/NET-384
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 3.0
>
>
> The clientKey manager performs some of the work that could be done as part of creating the key store.
> Since the manager is potentially called many times, it would be better to move the setup processing to the creation of the keystore.
> This requires creating a sub-class of KeyStore, which might as well be a private class created by createClientKeyManager()
> The calling sequence would then be:
> {code}
> KeyManager km = KeyManagerUtils.createClientKeyManager(
>     "JKS", "/path/to/privatekeystore.jks", "storepassword", "privatekeyalias", "keypassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}
> For JKS stores with a single entry and keypassword == storepassword this would simplify to:
> {code}
> KeyManager km = KeyManagerUtils.createClientKeyManager("/path/to/privatekeystore.jks", "storepassword");
> FTPSClient cl = new FTPSClient();
> cl.setKeyManager(km);
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira