[GitHub] [shardingsphere] liuxiaocs7 commented on issue #24756: Improve properties verification of ShardingAlgorithm

["liuxiaocs7 (via GitHub)" <gi...@apache.org>]

liuxiaocs7 commented on issue #24756:
URL: https://github.com/apache/shardingsphere/issues/24756#issuecomment-1515202404

   Hi, @Pace2Car, thanks for your reminder, I've been a little busy recently so I'm a little behind schedule. At present, the implementation of `ClassBasedShardingAlgorithm` has been completed, could you help me to have a look at it in your free time?
   
   I am not sure whether this modification meets the requirements. My understanding is to enhance the verification rules for the attribute values ​​input in the configuration, and modify the test program accordingly. Does `AlgorithmClassName` need to be further verified by reflection in the `getAlgorithmClassName` method? I see the current logic is in `ClassBasedShardingAlgorithmFactory`.
   
   There are also some other questions. There are many `sharding expressions` and `time format` judgments about the sharding algorithm. Is there any tool class for this part in the project before to check whether it is a valid sharding expression or time format.
   
   I will modify it according to your comments as soon as possible and continue to complete other verifications, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org