You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2014/08/01 00:16:12 UTC

[GitHub] spark pull request: SPARK-2664. Deal with `--conf` options in spar...

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1665#discussion_r15673470
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -184,7 +184,7 @@ object SparkSubmit {
           OptionAssigner(args.archives, YARN, CLIENT, sysProp = "spark.yarn.dist.archives"),
     
           // Yarn cluster only
    -      OptionAssigner(args.name, YARN, CLUSTER, clOption = "--name", sysProp = "spark.app.name"),
    --- End diff --
    
    It was first added in #699, but in #1538 we made `spark.app.name` available for all deploy modes and all cluster managers, which includes yarn-cluster. With these changes setting `spark.app.name` again here becomes redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---