You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/06/22 07:35:11 UTC

[GitHub] [iceberg] Fokko opened a new pull request, #7876: Python: Log to logging instead of warn

Fokko opened a new pull request, #7876:
URL: https://github.com/apache/iceberg/pull/7876

   I was doing some final testing befor the release, and noticed that when you don't have PyArrow installed (only s3fs), and you try to describe a table, you'll get a warning:
   
   ```
   root@0d64c149ba01:/vo# pyiceberg describe dbt_tabular.rides
   /vo/pyiceberg/io/__init__.py:283: UserWarning: Could not initialize FileIO: pyiceberg.io.pyarrow.PyArrowFileIO
     warnings.warn(f"Could not initialize FileIO: {io_impl}")
   Table format version  1
   
   Metadata location
   s3://tabular-wh-us-east-1/6efbcaf4-21ae-499d-b340-3bc1a7003f52/f59f662e-878f-42e4-8b66-04b076c8ee23/metadata/00037-c9977e9d-64d7-45fc-a93a-7e10efdfecc9.gz.metadat…
   Table UUID            f59f662e-878f-42e4-8b66-04b076c8ee23
   
   Last Updated          1684818900590
   
   Partition spec        []
   
   Sort order            []
   
   Current schema        Schema, id=13
   
                         ├── 1: vendor: optional string (TPEP provider that provided the record)
   
                         ├── 2: pickup_time: optional timestamptz (The date and time when the meter was engaged.)
   
                         ├── 3: pickup_zone_name: optional string (Taxi Zone in which the taximeter was engaged.)
   
                         ├── 4: pickup_borough: optional string (Borough in which the taximeter was engaged.)
   
                         ├── 5: dropoff_time: optional timestamptz (The date and time when the meter was disengaged.)
   
                         ├── 6: dropoff_zone_name: optional string (Taxi Zone in which the taximeter was disengaged)
   
                         ├── 7: dropoff_borough: optional string (Borough in which the taximeter was disengaged)
   
                         ├── 8: passenger_count: optional int (The number of passengers in the vehicle (This is a driver-entered value).)
   ```
   
   I think it makes more sense to send this to logging so you don't see it in the console.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko merged pull request #7876: Python: Log to logging instead of warn

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7876:
URL: https://github.com/apache/iceberg/pull/7876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] Fokko commented on pull request #7876: Python: Log to logging instead of warn

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7876:
URL: https://github.com/apache/iceberg/pull/7876#issuecomment-1604539382

   Thanks @rdblue for the quick review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #7876: Python: Log to logging instead of warn

Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #7876:
URL: https://github.com/apache/iceberg/pull/7876#issuecomment-1604522305

   Looks good, but there are CI failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org