You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2007/03/23 17:10:32 UTC

[jira] Created: (GERONIMO-3008) jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.

jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.
------------------------------------------------------------

                 Key: GERONIMO-3008
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3008
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
    Affects Versions: 2.0-beta1
            Reporter: David Jencks
         Assigned To: Tim McConnell
             Fix For: 2.0-beta1


an attribute like this:

        <attribute>
            <name>doEndTag</name>
            <required>true</required>
            <type>java.lang.String</type>
        </attribute>

is legal in 2.0 but not 2.1 where the type needs to be preceded with <rtexprvalue>true/false</rtexprvalue>

It looks to me from the 2.1 schema that the default is supposed to be false but it might be a good idea if someone who knows what it's supposed to mean verifies this.

I suspect this is a result of an error in the 2.1 jsp schema but there's nothing we can do about it now AFAIK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3008) jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483858 ] 

David Jencks commented on GERONIMO-3008:
----------------------------------------

the jstl 1.0 tld would be a good testcase.  I think the test might have to extract it from teh jstl jar, I don't think we should check in the tld ourselves due to possible sun copyright issues.  I haven't looked for the specific terms though.  I am seeing 4 errors from the conversion.

> jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3008
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3008
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.0-beta1
>            Reporter: David Jencks
>         Assigned To: Tim McConnell
>             Fix For: 2.0-beta1
>
>         Attachments: JspModuleBuilderExtension.java
>
>
> an attribute like this:
>         <attribute>
>             <name>doEndTag</name>
>             <required>true</required>
>             <type>java.lang.String</type>
>         </attribute>
> is legal in 2.0 but not 2.1 where the type needs to be preceded with <rtexprvalue>true/false</rtexprvalue>
> It looks to me from the 2.1 schema that the default is supposed to be false but it might be a good idea if someone who knows what it's supposed to mean verifies this.
> I suspect this is a result of an error in the 2.1 jsp schema but there's nothing we can do about it now AFAIK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3008) jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.

Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim McConnell updated GERONIMO-3008:
------------------------------------

    Attachment: JspModuleBuilderExtension.java

Added support for 2.0 to 2.1 XSD schema conversion

> jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3008
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3008
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.0-beta1
>            Reporter: David Jencks
>         Assigned To: Tim McConnell
>             Fix For: 2.0-beta1
>
>         Attachments: JspModuleBuilderExtension.java
>
>
> an attribute like this:
>         <attribute>
>             <name>doEndTag</name>
>             <required>true</required>
>             <type>java.lang.String</type>
>         </attribute>
> is legal in 2.0 but not 2.1 where the type needs to be preceded with <rtexprvalue>true/false</rtexprvalue>
> It looks to me from the 2.1 schema that the default is supposed to be false but it might be a good idea if someone who knows what it's supposed to mean verifies this.
> I suspect this is a result of an error in the 2.1 jsp schema but there's nothing we can do about it now AFAIK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-3008) jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.

Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim McConnell closed GERONIMO-3008.
-----------------------------------

    Resolution: Fixed

Fixed with patches applied to GERONIMO-2965

> jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3008
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3008
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.0-M4
>            Reporter: David Jencks
>         Assigned To: Tim McConnell
>             Fix For: 2.0-M4
>
>         Attachments: JspModuleBuilderExtension.java
>
>
> an attribute like this:
>         <attribute>
>             <name>doEndTag</name>
>             <required>true</required>
>             <type>java.lang.String</type>
>         </attribute>
> is legal in 2.0 but not 2.1 where the type needs to be preceded with <rtexprvalue>true/false</rtexprvalue>
> It looks to me from the 2.1 schema that the default is supposed to be false but it might be a good idea if someone who knows what it's supposed to mean verifies this.
> I suspect this is a result of an error in the 2.1 jsp schema but there's nothing we can do about it now AFAIK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3008) jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483846 ] 

David Jencks commented on GERONIMO-3008:
----------------------------------------

Applied in rev 522036.  I think there are some more upgrade issues so I'm leaving this open while we investigate.

I turned off validation of the transformed tld files.... to see errors turn it on again.

> jsp taglib schema changes from 2.0 to 2.1 make upgrade hard.
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3008
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3008
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>    Affects Versions: 2.0-beta1
>            Reporter: David Jencks
>         Assigned To: Tim McConnell
>             Fix For: 2.0-beta1
>
>         Attachments: JspModuleBuilderExtension.java
>
>
> an attribute like this:
>         <attribute>
>             <name>doEndTag</name>
>             <required>true</required>
>             <type>java.lang.String</type>
>         </attribute>
> is legal in 2.0 but not 2.1 where the type needs to be preceded with <rtexprvalue>true/false</rtexprvalue>
> It looks to me from the 2.1 schema that the default is supposed to be false but it might be a good idea if someone who knows what it's supposed to mean verifies this.
> I suspect this is a result of an error in the 2.1 jsp schema but there's nothing we can do about it now AFAIK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.