You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/07 23:57:12 UTC

[GitHub] [spark] rdblue commented on a change in pull request #25305: [SPARK-28572][SQL] Simple analyzer checks for v2 table creation code paths

rdblue commented on a change in pull request #25305: [SPARK-28572][SQL] Simple analyzer checks for v2 table creation code paths
URL: https://github.com/apache/spark/pull/25305#discussion_r311809015
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
 ##########
 @@ -1193,3 +1211,17 @@ case class Deduplicate(
 
   override def output: Seq[Attribute] = child.output
 }
+
+/** A trait used for logical plan nodes that create or replace V2 table definitions. */
+sealed trait V2TableCreation extends LogicalPlan {
 
 Review comment:
   This name seems awkward to me. What about `CreateTablePlan` or `V2CreateTablePlan`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org