You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/15 09:49:57 UTC
[GitHub] [trafficserver] zds05 opened a new pull request #7002: fix plugin slice throttle not work
zds05 opened a new pull request #7002:
URL: https://github.com/apache/trafficserver/pull/7002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on a change in pull request #7002: fix plugin slice throttle not work
Posted by GitBox <gi...@apache.org>.
traeak commented on a change in pull request #7002:
URL: https://github.com/apache/trafficserver/pull/7002#discussion_r455312475
##########
File path: iocore/aio/AIO.cc
##########
@@ -24,7 +24,6 @@
/*
* Async Disk IO operations.
*/
-
Review comment:
agreed. This PR should fix a dumb bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] traeak commented on a change in pull request #7002: fix plugin slice throttle not work
Posted by GitBox <gi...@apache.org>.
traeak commented on a change in pull request #7002:
URL: https://github.com/apache/trafficserver/pull/7002#discussion_r455312475
##########
File path: iocore/aio/AIO.cc
##########
@@ -24,7 +24,6 @@
/*
* Async Disk IO operations.
*/
-
Review comment:
agreed. This PR fixes a dumb bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zds05 closed pull request #7002: fix plugin slice throttle not work
Posted by GitBox <gi...@apache.org>.
zds05 closed pull request #7002:
URL: https://github.com/apache/trafficserver/pull/7002
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a change in pull request #7002: fix plugin slice throttle not work
Posted by GitBox <gi...@apache.org>.
randall commented on a change in pull request #7002:
URL: https://github.com/apache/trafficserver/pull/7002#discussion_r455151897
##########
File path: iocore/aio/AIO.cc
##########
@@ -24,7 +24,6 @@
/*
* Async Disk IO operations.
*/
-
Review comment:
can you remove this line removal? It doesn't look related to the slice plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org