You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/08/11 02:28:18 UTC
[GitHub] [bigtop] vivostar opened a new pull request, #979: BIGTOP-3693. Support Docker Compose V2
vivostar opened a new pull request, #979:
URL: https://github.com/apache/bigtop/pull/979
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
-->
### Description of PR
Make docker-hadoop.sh support docker compose v2
### How was this patch tested?
```shell
./docker-hadoop.sh \
-d \
-dc2 \
--create 2 \
--image bigtop/puppet:trunk-centos-7 \
--memory 8g \
--repo http://repos.bigtop.apache.org/releases/3.1.0/centos/7/\$basearch \
--disable-gpg-check \
--stack hdfs,yarn,mapreduce,spark,hive
./docker-hadoop.sh \
-d \
-dc2 \
--create 2 \
--image bigtop/puppet:trunk-debian-10 \
--memory 8g \
--repo http://repos.bigtop.apache.org/releases/3.1.1/debian/10/\$\(ARCH\) \
--disable-gpg-check \
--stack hdfs,yarn,mapreduce,spark,hive
```
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
- [x] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] vivostar commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
vivostar commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1263082300
hi @sekikn, thanks for your advice, I have updated the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] vivostar commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
vivostar commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1263046799
test docker-hadoop.sh
1. start containers
```shell
./docker-hadoop.sh \
-d \
-dcp \
--create 2 \
--image bigtop/puppet:trunk-centos-7 \
--memory 8g \
--repo http://repos.bigtop.apache.org/releases/3.1.0/centos/7/\$basearch \
--disable-gpg-check \
--stack hdfs,yarn,mapreduce,spark,hive
./docker-hadoop.sh \
-d \
--docker-compose-plugin \
--create 2 \
--image bigtop/puppet:trunk-centos-7 \
--memory 8g \
--repo http://repos.bigtop.apache.org/releases/3.1.0/centos/7/\$basearch \
--disable-gpg-check \
--stack hdfs,yarn,mapreduce,spark,hive
```
2. stop containers
```
./docker-hadoop.sh -d -dcp # don't forget add the command line parameter
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1263066780
Thanks @vivostar! Would you rebase the PR on the latest master? It looks mergeable on GitHub, but it actually conflicts #1026 and seems to cancel that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1263130170
+1, tested with both "docker-compose" and "docker compose". @vivostar thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
sekikn commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1262983229
@vivostar As you mentioned, the plugin version of "docker compose" command is available in v2.
https://docs.docker.com/compose/#compose-v2-and-the-new-docker-compose-command
I think this change is useful for the users of that version (including me), so would you submit this PR again?
And in that PR, the option name `--docker-compose-v2` feels somewhat ambiguous to me if it refers to the yaml format or plugin command, so `--docker-compose-plugin` or something may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
guyuqi commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1214648451
The users could select the corresponding binaries of `docker-compose` for v1 and v2 from `https://github.com/docker/compose/releases`.
We've made docker-provisioner to be used both in docker-compose v1 and v2 : https://github.com/apache/bigtop/pull/903.
I'm afraid this PR is not about `support docker-compose v2`, but just provides the command for showing some inessential help-info .
To be honest, I don't think this PR makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] vivostar closed pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
vivostar closed pull request #979: BIGTOP-3693. Support Docker Compose V2
URL: https://github.com/apache/bigtop/pull/979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] vivostar commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
vivostar commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1214926482
@guyuqi , Thanks for your advice. When we use docker client v2, it's docker-compose is "docker compose". My dev machine is docker client v2, too, so when I test something I must change the docker-hadoop.sh. So I add the pr to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
sekikn merged PR #979:
URL: https://github.com/apache/bigtop/pull/979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] vivostar commented on pull request #979: BIGTOP-3693. Support Docker Compose V2
Posted by GitBox <gi...@apache.org>.
vivostar commented on PR #979:
URL: https://github.com/apache/bigtop/pull/979#issuecomment-1263022133
hi, @sekikn , thanks for your concern the issue, I will reopen the pr and work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org