You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Ray Davis (JIRA)" <my...@incubator.apache.org> on 2005/06/14 02:19:46 UTC
[jira] Created: (MYFACES-283) Bogus warning logged for servlets with "init-param"
Bogus warning logged for servlets with "init-param"
---------------------------------------------------
Key: MYFACES-283
URL: http://issues.apache.org/jira/browse/MYFACES-283
Project: MyFaces
Type: Bug
Versions: Nightly Build
Reporter: Ray Davis
Priority: Trivial
In 1.0.9 and the trunk, when a servlet configuration includes an "init-param", WebXmlParser (src/share/org/apache/myfaces/webapp/webxml/WebXmlParser.java) logs a warning:
WARN: Ignored element 'init-param' as child of 'servlet'.
This clutters up the log with distractions. Here's the responsible code:
private void readServlet(Element servletElem)
{
...
else if (n.getNodeName().equals("description") || n.getNodeName().equals("load-on-startup"))
{
//ignore
}
else
{
if (log.isWarnEnabled()) log.warn("Ignored element '" + n.getNodeName() + "' as child of '" + servletElem.getNodeName() + "'.");
}
Since init-param is a perfectly fine element, it should be ignored just like "load-on-startup".
Also, any element that MyFaces doesn't recognize should arguably be logged at an "info" level, like nodes that it doesn't recognize.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-283) Bogus warning logged for servlets with "init-param"
Posted by "sean schofield (JIRA)" <my...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-283?page=all ]
sean schofield closed MYFACES-283:
----------------------------------
Fix Version: Nightly Build
Resolution: Fixed
Ignoring init-param, all other problems are logged as debug instead of warn. Thanks for the detailed explanation of the problem and fix (makes it easier when going through our *vast* supply of JIRA issues.)
> Bogus warning logged for servlets with "init-param"
> ---------------------------------------------------
>
> Key: MYFACES-283
> URL: http://issues.apache.org/jira/browse/MYFACES-283
> Project: MyFaces
> Type: Bug
> Versions: Nightly Build
> Reporter: Ray Davis
> Assignee: sean schofield
> Priority: Trivial
> Fix For: Nightly Build
>
> In 1.0.9 and the trunk, when a servlet configuration includes an "init-param", WebXmlParser (src/share/org/apache/myfaces/webapp/webxml/WebXmlParser.java) logs a warning:
> WARN: Ignored element 'init-param' as child of 'servlet'.
> This clutters up the log with distractions. Here's the responsible code:
> private void readServlet(Element servletElem)
> {
> ...
> else if (n.getNodeName().equals("description") || n.getNodeName().equals("load-on-startup"))
> {
> //ignore
> }
> else
> {
> if (log.isWarnEnabled()) log.warn("Ignored element '" + n.getNodeName() + "' as child of '" + servletElem.getNodeName() + "'.");
> }
> Since init-param is a perfectly fine element, it should be ignored just like "load-on-startup".
> Also, any element that MyFaces doesn't recognize should arguably be logged at an "info" level, like nodes that it doesn't recognize.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira