You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/12/29 10:41:47 UTC
[GitHub] eolivelli commented on a change in pull request #1893: Update
ServerConfiguration to use ConfigKey and ConfigKeyGroup
eolivelli commented on a change in pull request #1893: Update ServerConfiguration to use ConfigKey and ConfigKeyGroup
URL: https://github.com/apache/bookkeeper/pull/1893#discussion_r244472327
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##########
@@ -68,93 +69,498 @@
DEFAULT_LOADER = loader;
}
- // Zookeeper Parameters
- protected static final String ZK_TIMEOUT = "zkTimeout";
- protected static final String ZK_SERVERS = "zkServers";
+ //
+ // Metadata Service Settings
+ //
+
+ protected static final ConfigKeyGroup GROUP_METADATA_SERVICE = ConfigKeyGroup.builder("metadataservice")
+ .description("Metadata Service related settings")
+ .order(0)
+ .build();
+
+ protected static final String METADATA_SERVICE_URI = "metadataServiceUri";
+ protected static final ConfigKey METADATA_SERVICE_URI_KEY = ConfigKey.builder(METADATA_SERVICE_URI)
+ .type(Type.STRING)
+ .description("metadata service uri that bookkeeper is used for loading corresponding metadata driver"
Review comment:
Typo 'is used' -> 'uses'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services