[jira] [Commented] (ATLAS-1726) Creating type name with space causes exceptions while doing DSL search

["David Radley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ATLAS-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967366#comment-15967366 ] 

David Radley commented on ATLAS-1726:
-------------------------------------

[~sarath.kum4r@gmail.com] This is a good catch.
I notice http://www.json.org/ talks of valid json strings as any unicode character apart from " or \. I am not sure whether our Jackson json support introduces more restrictions. 

 I wonder do we : 
1) support blanks in type names. If we do presumably we should support blanks in the other type related structures like AttributeDef names. We may not want to support an uni-code characters as type names, leading blank characters in type names, leading numbers. Whether we support non-english characters is another question, the advantage of sticking to English characters is that it helps debugging; but there should then be a way to globalise these strings.  
2) We  do not support type names with blanks in and are much more restrictive in the characters - for example see https://db.apache.org/derby/docs/10.1/ref/crefsqlj1003454.html.  

In both cases we should explicitly document/police exactly which characters are supported and any encoding restrictions. We should also police document the maximum length. It would be great to see a set of unit tests to tests all the valid and invalids here.  




> Creating type name with space causes exceptions while doing DSL search
> ----------------------------------------------------------------------
>
>                 Key: ATLAS-1726
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1726
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.8-incubating, 0.9-incubating
>            Reporter: Sharmadha Sainath
>            Assignee: Sarath Subramanian
>
> 1.Created a type "type 1" successfully
> 2.Searched the type "type 1" in Basic search which worked fine.
> 3.Same type when selected in drop down list of types in DSL , failed with 500 internal server error with exception :
> {code}
> org.apache.atlas.query.Expressions$UnresolvedException: Unresolved datatype. Can not resolve due to unresolved children, expression: type where 1
> {code}
> 4. If typename is provided as `type 1` in "Search by Query" text box (with backquotes) like mentioned in https://issues.apache.org/jira/browse/ATLAS-263 , it works fine.
> User might perceive that the type is not registered properly due to the exception.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)