[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3610: [HOTFIX] Concurrent insert test case failure fix

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3610: [HOTFIX] Concurrent insert test case failure fix
URL: https://github.com/apache/carbondata/pull/3610#discussion_r377471467
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
 ##########
 @@ -290,7 +290,7 @@ case class CarbonLoadDataCommand(
           FileFactory.mkdirs(metadataDirectoryPath)
         }
       } else {
-        carbonLoadModel.setSegmentId(System.currentTimeMillis().toString)
+        carbonLoadModel.setSegmentId(System.nanoTime().toString)
 
 Review comment:
   Many times have observed (mainly from user environment) that , two concurrent tasks can get same nano time. So, we use UUID in these scenario. But for segmentID we cannot use as it as may be  segment id will be casted to long. 
   
   Need other solutions or go back to old look up logic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services