You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/08 23:58:26 UTC
Re: Review Request 70117: WIP: Added unit tests for offer operation
feedback metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
-----------------------------------------------------------
(Updated March 8, 2019, 11:58 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Summary (updated)
-----------------
WIP: Added unit tests for offer operation feedback metrics.
Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241
Repository: mesos
Description (updated)
-------
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/3/
Changes: https://reviews.apache.org/r/70117/diff/2-3/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213985
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70115, 70156, 70185, 70116, 70117]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review214185
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On March 27, 2019, 4:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 4:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70117/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review214118
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 70116.
Failed command: `python.exe .\support\apply-reviews.py -n -r 70116`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3028/mesos-review-70117
Relevant logs:
- [apply-review-70116.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3028/mesos-review-70117/logs/apply-review-70116.log):
```
error: patch failed: src/master/master.cpp:8781
error: src/master/master.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On March 27, 2019, 4:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 4:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70117/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review214125
-----------------------------------------------------------
Bad review!
Reviews applied: [70117, 70116, 70156, 70115]
Error:
2019-03-27 17:53:05 URL:https://reviews.apache.org/r/70116/diff/raw/ [18838/18838] -> "70116.patch" [1]
error: patch failed: src/master/master.cpp:8781
error: src/master/master.cpp: patch does not apply
- Mesos Reviewbot
On March 27, 2019, 4:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 4:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70117/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
-----------------------------------------------------------
(Updated March 27, 2019, 4:41 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Verify that 'pending' is correctly decreased; remove newline.
Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241
Repository: mesos
Description
-------
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
Diff: https://reviews.apache.org/r/70117/diff/7/
Changes: https://reviews.apache.org/r/70117/diff/6-7/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review214062
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70115', '70156', '70116', '70117']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3019/mesos-review-70117
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3019/mesos-review-70117/logs/mesos-tests.log):
```
I0326 19:40:26.126857 38252 http.cpp:1105] HTTP POST for /slave(345)/api/v1/resource_provider from 192.10.1.6:62105
I0326 19:40:26.128854 33520 manager.cpp:742] Subscribing resource provider {"name":"test","type":"org.apache.mesos.rp.test"}
I0326 19:40:26.130851 38252 slave.cpp:8111] Handling resource provider message 'SUBSCRIBE: {"id":{"value":"69e2658c-6b08-46cd-8b7b-e37b009d1878"},"name":"test","type":"org.apache.mesos.rp.test"}'
I0326 19:40:26.138867 2240 http.cpp:1105] HTTP POST for /slave(345)/api/v1/resource_provider from 192.10.1.6:62104
I0326 19:40:26.139888 24712 manager.cpp:941] Received UPDATE_STATE call with resources '[{"disk":{"source":{"type":"RAW"}},"name":"disk","provider_id":{"value":"69e2658c-6b08-46cd-8b7b-e37b009d1878"},"scalar":{"value":200.0},"type":"SCALAR"}]' and 0 operations from resource provider 69e2658c-6b08-46cd-8b7b-e37b009d1878
I0326 19:40:26.140852 36940 slave.cpp:8111] Handling resource provider message 'UPDATE_STATE: 69e2658c-6b08-46cd-8b7b-e37b009d1878 disk[RAW]:200'
I0326 19:40:26.140852 36940 slave.cpp:8231] Forwarding new total resources cpus:4; mem:2048; disk:1024; ports:[31000-32000]; disk[RAW]:200
I0326 19:40:26.145856 37860 hierarchical.cpp:739] Agent 6d313d33-01ab-401c-8749-60dcf1ac7762-S0 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) updated with total resources cpus:4; mem:2048; disk:1024; ports:[31000-32000]; disk[RAW]:200
I0326 19:40:26.158850 33468 scheduler.cpp:189] Version: 1.8.0
I0326 19:40:26.159850 24712 scheduler.cpp:342] Using default 'basic' HTTP authenticatee
I0326 19:40:26.159850 33520 scheduler.cpp:525] New master detected at master@192.10.1.6:60396
I0326 19:40:26.171849 37860 http.cpp:1105] HTTP POST for /master/api/v1/scheduler from 192.10.1.6:62107
I0326 19:40:26.172873 37860 master.cpp:2568] Received subscription request for HTTP framework 'default'
I0326 19:40:26.172873 37860 master.cpp:2213] Authorizing framework principal 'test-principal' to receive offers for roles '{ default-role }'
I0326 19:40:26.174870 37860 master.cpp:2703] Subscribing framework 'default' with checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0326 19:40:26.182866 37860 master.cpp:10348] Adding framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000 (default) with roles { } suppressed
I0326 19:40:26.184855 2240 hierarchical.cpp:338] Added framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000
I0326 19:40:26.188869 32656 master.cpp:9933] Sending offers [ 6d313d33-01ab-401c-8749-60dcf1ac7762-O0 ] to framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000 (default)
I0326 19:40:26.202859 2240 http.cpp:1105] HTTP POST for /master/api/v1/scheduler from 192.10.1.6:62106
I0326 19:40:26.203861 2240 master.cpp:12190] Removing offer 6d313d33-01ab-401c-8749-60dcf1ac7762-O0
I0326 19:40:26.205868 2240 master.cpp:4587] Processing ACCEPT call for offers: [ 6d313d33-01ab-401c-8749-60dcf1ac7762-O0 ] on agent 6d313d33-01ab-401c-8749-60dcf1ac7762-S0 at slave(345)@192.10.1.6:60396 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) for framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000 (default)
I0326 19:40:26.205868 2240 master.cpp:3675] Authorizing principal 'test-principal' to reserve resources 'disk(allocated: default-role)(reservations: [(DYNAMIC,default-role,test-principal)])[RAW]:200'
I0326 19:40:26.208854 2240 master.cpp:4956] Applying RESERVE operation for resources [{"allocation_info":{"role":"default-role"},"disk":{"source":{"type":"RAW"}},"name":"disk","provider_id":{"value":"69e2658c-6b08-46cd-8b7b-e37b009d1878"},"reservations":[{"principal":"test-principal","role":"default-role","type":"DYNAMIC"}],"scalar":{"value":200.0},"type":"SCALAR"}] from framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000 (default) to agent 6d313d33-01ab-401c-8749-60dcf1ac7762-S0 at slave(345)@192.10.1.6:60396 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0326 19:40:26.210860 2240 master.cpp:12081] Sending operation 'operation' (uuid: 6df406f6-9335-4322-9332-275bb2b7235d) to agent 6d313d33-01ab-401c-8749-60dcf1ac7762-S0 at slave(345)@192.10.1.6:60396 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0326 19:40:26.215867 36940 hierarchical.cpp:996] Updated allocation of framework 6d313d33-01ab-401c-8749-60dcf1ac7762-0000 on agent 6d313d33-01ab-401c-8749-60dcf1ac7762-S0 from cpus(allocated: default-role):4; mem(allocated: default-role):2048; disk(allocated: default-role):1024; ports(allocated: default-role):[31000-32000]; disk(allocated: default-role)[RAW]:200 to cpus(allocated: default-role):4; mem(allocated: default-role):2048; disk(allocated: default-role):1024; ports(allocated: default-role):[31000-32000]; disk(allocated: default-role)(reservations: [(DYNAMIC,default-role,test-principal)])[RAW]:200
I0326 19:40:26.224861 24712 http.cpp:1105] HTTP POST for /master/api/v1 from 192.10.1.6:62108
I0326 19:40:26.224861 24712 http.cpp:260] Processing call MARK_AGENT_GONE
I0326 19:40:26.225850 35656 http.cpp:4102] Marking agent '6d313d33-01ab-401c-8749-60dcf1ac7762-S0' as gone
I0326 19:40:26.226850 36940 registrar.cpp:487] Applied 1 operations in 0ns; attempting to update the r
```
- Mesos Reviewbot Windows
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213685
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70115, 70156, 70185, 70116, 70117]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
> On March 15, 2019, 12:01 a.m., Greg Mann wrote:
> > Could you also update a test to verify that metrics transition correctly? i.e., that operation metrics will start at `pending == 0` and `finished == 0`, then transition to `pending == 1` and `finished == 0`, then finally to `pending == 0` and `finished == 1`? Would be nice to do this for both the global and per-operation metrics.
Good point, I've added this check to `MasterTests.OperationUpdateDuringFailover`.
As an interesting aside, this was the *only* test in our whole test suite that I could find where an operation transitions out of the `PENDING` state, maybe that indicates we're missing some test to verify the basic operation lifecycle.
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213732
-----------------------------------------------------------
On March 27, 2019, 4:41 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 27, 2019, 4:41 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 8bd1dc02a74c4e6c1b97b25e73098c0b75f2d38e
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 797f89e3545965e2cf2fd5ec0ecd78fc77a4ea87
>
>
> Diff: https://reviews.apache.org/r/70117/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213732
-----------------------------------------------------------
Could you also update a test to verify that metrics transition correctly? i.e., that operation metrics will start at `pending == 0` and `finished == 0`, then transition to `pending == 1` and `finished == 0`, then finally to `pending == 0` and `finished == 1`? Would be nice to do this for both the global and per-operation metrics.
src/tests/persistent_volume_endpoints_tests.cpp
Line 1681 (original), 1683-1686 (patched)
<https://reviews.apache.org/r/70117/#comment299711>
Nit: too many newlines.
- Greg Mann
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213986
-----------------------------------------------------------
PASS: Mesos patch 70117 was successfully built and tested.
Reviews applied: `['70115', '70156', '70185', '70116', '70117']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3007/mesos-review-70117
- Mesos Reviewbot Windows
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213673
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['70115', '70156', '70185', '70116', '70117']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2930/mesos-review-70117
Relevant logs:
- [stout-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2930/mesos-review-70117/logs/stout-tests.log):
```
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (1 ms)
[ RUN ] SocketTests.IntFD
[ OK ] SocketTests.IntFD (1 ms)
[----------] 2 tests from SocketTests (2 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (0 ms total)
[----------] 2 tests from OsSendfileTest
[ RUN ] OsSendfileTest.Sendfile
[ OK ] OsSendfileTest.Sendfile (1248 ms)
[ RUN ] OsSendfileTest.SendfileAsync
[ OK ] OsSendfileTest.SendfileAsync (18 ms)
[----------] 2 tests from OsSendfileTest (1266 ms total)
[----------] Global test environment tear-down
[==========] 345 tests from 53 test cases ran. (7675 ms total)
[ PASSED ] 344 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] OsTest.Children
1 FAILED TEST
YOU HAVE 1 DISABLED TEST
```
- Mesos Reviewbot Windows
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
-----------------------------------------------------------
(Updated March 13, 2019, 4:01 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Removed one more line.
Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241
Repository: mesos
Description
-------
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/6/
Changes: https://reviews.apache.org/r/70117/diff/5-6/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
-----------------------------------------------------------
(Updated March 13, 2019, 3:51 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Fixed flakiness observed in CI.
Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241
Repository: mesos
Description
-------
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/5/
Changes: https://reviews.apache.org/r/70117/diff/4-5/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
> On March 13, 2019, 12:29 a.m., Joseph Wu wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 3832-3845 (original), 3833-3846 (patched)
> > <https://reviews.apache.org/r/70117/diff/4/?file=2130951#file2130951line3833>
> >
> > In cases like this, it would be more appropriate to use `Metrics()` since we'd otherwise make multiple calls to `/metrics/snapshot` for each metric.
> >
> > Alternatively, you could add a verion of the `metricsEqual` which takes a map. The downside of a helper is that reporting which metric(s) don't match would be harder.
> >
> > ... also you forgot to delete `snapshot = Metrics();` ;)
I actually thought about your first point when implementing this, but thought that readability would be more important than shaving off a few milliseconds from a test case.
Regarding the `snapshot`, you are of course right and I should have read the comment before pushing the next revision ;)
- Benno
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213641
-----------------------------------------------------------
On March 13, 2019, 4:01 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 13, 2019, 4:01 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/#review213641
-----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp
Lines 3832-3845 (original), 3833-3846 (patched)
<https://reviews.apache.org/r/70117/#comment299639>
In cases like this, it would be more appropriate to use `Metrics()` since we'd otherwise make multiple calls to `/metrics/snapshot` for each metric.
Alternatively, you could add a verion of the `metricsEqual` which takes a map. The downside of a helper is that reporting which metric(s) don't match would be harder.
... also you forgot to delete `snapshot = Metrics();` ;)
- Joseph Wu
On March 11, 2019, 12:15 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70117/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 12:15 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Bugs: MESOS-8241
> https://issues.apache.org/jira/browse/MESOS-8241
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds a set of checks to verify the metrics introduced
> in the previous commit are working as intended.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
> src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
> src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
> src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
> src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
> src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
> src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
> src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
> src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
> src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
>
>
> Diff: https://reviews.apache.org/r/70117/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70117: Added unit tests for offer operation
feedback metrics.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70117/
-----------------------------------------------------------
(Updated March 11, 2019, 7:15 p.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Fixed deadlocks.
Summary (updated)
-----------------
Added unit tests for offer operation feedback metrics.
Bugs: MESOS-8241
https://issues.apache.org/jira/browse/MESOS-8241
Repository: mesos
Description
-------
This adds a set of checks to verify the metrics introduced
in the previous commit are working as intended.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp 5a8f54c7c53272e90ed5fa6366e8154cedf1375f
src/tests/api_tests.cpp f241064dc8597972299a424958e759588f7e4fd2
src/tests/master_slave_reconciliation_tests.cpp 002be27bf0731e2dba89376911117b347cd1dd0a
src/tests/master_tests.cpp 5a926831734e6acf0388a63dac3ea3559b44a6a9
src/tests/operation_reconciliation_tests.cpp 6a815ad694e2a608ce324715c920833f825793a0
src/tests/persistent_volume_endpoints_tests.cpp 40d7e6a30c9c11eb84f4bd5aca92cfcecb3e0eb7
src/tests/reservation_endpoints_tests.cpp b1897592797c40574de7995b2335f2b4bc5fc699
src/tests/scheduler_tests.cpp 5fb696061248c877bfa86727f146051aee26cb58
src/tests/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
src/tests/storage_local_resource_provider_tests.cpp 7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70117/diff/4/
Changes: https://reviews.apache.org/r/70117/diff/3-4/
Testing
-------
Thanks,
Benno Evers