You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/02/06 19:55:12 UTC

Review Request 17802: Remove /api/v1 from Pass Through API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17802/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-4549
    https://issues.apache.org/jira/browse/AMBARI-4549


Repository: ambari


Description
-------

We've decided that we should keep this feature separate from the REST API to avoid confusion. Please remove '/api/v1' and simply use 'proxy'.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java 9e457c6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee 
  ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 3f219dd 
  ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/17802/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 17802: Remove /api/v1 from Pass Through API

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17802/#review33822
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 6, 2014, 1:55 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17802/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 1:55 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4549
>     https://issues.apache.org/jira/browse/AMBARI-4549
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We've decided that we should keep this feature separate from the REST API to avoid confusion. Please remove '/api/v1' and simply use 'proxy'.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java 9e457c6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 3f219dd 
>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17802/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 17802: Remove /api/v1 from Pass Through API

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17802/#review33818
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Feb. 6, 2014, 6:55 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17802/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 6:55 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-4549
>     https://issues.apache.org/jira/browse/AMBARI-4549
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We've decided that we should keep this feature separate from the REST API to avoid confusion. Please remove '/api/v1' and simply use 'proxy'.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ProxyService.java 9e457c6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java faaf0ee 
>   ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/ProxyServiceTest.java 3f219dd 
>   ambari-server/src/test/java/org/apache/ambari/server/proxy/ProxyServiceTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17802/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>