[jira] Commented: (TIKA-335) TXTParser should use incoming charset

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TIKA-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783511#action_12783511 ] 

Jukka Zitting commented on TIKA-335:
------------------------------------

Looks good, thanks!

Is the new UTF-8/ISO-8859-1 test case supposed to pass? I'm getting the following test failure after I apply the patch:

testUseIncomingCharsetAsHint(org.apache.tika.parser.txt.TXTParserTest)  Time elapsed: 0.007 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:<ISO-8859-1> but was:<UTF-8>
        at junit.framework.Assert.assertEquals(Assert.java:81)
        at junit.framework.Assert.assertEquals(Assert.java:87)
        at org.apache.tika.parser.txt.TXTParserTest.testUseIncomingCharsetAsHint(TXTParserTest.java:121)


> TXTParser should use incoming charset
> -------------------------------------
>
>                 Key: TIKA-335
>                 URL: https://issues.apache.org/jira/browse/TIKA-335
>             Project: Tika
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Ken Krugler
>            Priority: Minor
>         Attachments: TIKA-335.patch
>
>
> The incoming charset (if any) from metadata should be passed to CharsetDetector.setDeclaredEncoding().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.