You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/14 15:45:54 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2036: Scheduled Workflow Znode - doesn't purge old entries
desaikomal opened a new pull request, #2036:
URL: https://github.com/apache/helix/pull/2036
With this change, we are introducing history of last 100 scheduled tasks and
making sure we purge the previous entries.
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
### Description
- [] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #2036: Scheduled Workflow Znode - doesn't purge old entries
Posted by GitBox <gi...@apache.org>.
narendly commented on PR #2036:
URL: https://github.com/apache/helix/pull/2036#issuecomment-1100176656
A suggestion for writing good commit messages - https://cbea.ms/git-commit/
So ideally it should say something like "Fix a bug in scheduled workflow history" and your description can have a more thorough description/context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a diff in pull request #2036: Scheduled Workflow Znode - doesn't purge old entries
Posted by GitBox <gi...@apache.org>.
narendly commented on code in PR #2036:
URL: https://github.com/apache/helix/pull/2036#discussion_r851329534
##########
helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java:
##########
@@ -57,6 +57,9 @@ protected enum WorkflowContextProperties {
// Otherwise, the context will not be written to ZK by the controller.
private boolean isModified;
+ // Have fixed size history of Scheduled Workflow Tasks
+ private final static int SCHEDULED_WORKFLOW_HISTORY_SIZE = 100;
Review Comment:
Thanks for making the fix. For the size here, should we use something smaller like 20?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2036: Fixed size history for Scheduled Workflow tasks
Posted by GitBox <gi...@apache.org>.
desaikomal commented on PR #2036:
URL: https://github.com/apache/helix/pull/2036#issuecomment-1100279526
This PR is ready to merge, approved by @narendly
Commit message:
Fixed size history for Scheduled Workflow tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #2036: Fixed size history for Scheduled Workflow tasks
Posted by GitBox <gi...@apache.org>.
narendly merged PR #2036:
URL: https://github.com/apache/helix/pull/2036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2036: Fixed size history for Scheduled Workflow tasks
Posted by GitBox <gi...@apache.org>.
desaikomal commented on code in PR #2036:
URL: https://github.com/apache/helix/pull/2036#discussion_r851398868
##########
helix-core/src/main/java/org/apache/helix/task/WorkflowContext.java:
##########
@@ -57,6 +57,9 @@ protected enum WorkflowContextProperties {
// Otherwise, the context will not be written to ZK by the controller.
private boolean isModified;
+ // Have fixed size history of Scheduled Workflow Tasks
+ private final static int SCHEDULED_WORKFLOW_HISTORY_SIZE = 100;
Review Comment:
Thanks for review. Reduced to 20.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org