You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:09:23 UTC
[GitHub] [geode-native] jvarenina opened a new pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
jvarenina opened a new pull request #866:
URL: https://github.com/apache/geode-native/pull/866
Fault:
Client clears result by calling ResultCollector::clearResult and
re-executes the function even thought Function.isHa() is set to false.
Fix:
Client will not clear result and retry the function, but it will fail with the
received exception from server.
Added integration test:
1.FunctionExecutionTest.testThatFunctionExecutionThrowsExceptionNonHAWithFilter
2.FunctionExecutionTest.testThatFunctionExecutionThrowsExceptionNonHA
The integration test reproduces the problem in a following way:
1. Populate region so that all buckets are created
2. Shutdown one of the three available servers
3. Peforme rebalance operation, so that buckets are recovered on running
servers
4. Execute the function. Function execution will fail with the
InternalFunctionInvocationTargetException exception, because client will
try to execute single hop function with old PR meatada information (PR
metadata received before the rebalance operation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina edited a comment on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina edited a comment on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-919033963
I put as review ready even thought two test jobs failed, because I think that failed test cases could be flaky:
- HARegionCacheListenerARLTest.afterRegionLive (concourse-ci/build-ubuntu-16.04-debug )
- TransactionCleaningTest.txWithStoppedServer (concourse-ci/build-ubuntu-18.04-debug)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-940368602
Hi @pdxcodemonkey ,
I just fixed my test cases in commit: https://github.com/apache/geode-native/pull/866/commits/0599097f0c062419edb27dd25e406cf53982acde . The problem was that rebalance operation was not triggered at all. Also, I improved the cases in a way that now rebalance is triggered after new server is introduced in cluster, as this works better for this case. I run them multiple times on my local machine and everything worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-936911852
@jvarenina This one needs a little attention, I think. If you rebase to fix the merge conflicts, we can look at the resultant CI run and see if there are any lingering test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-919033963
I put as review ready even thought two test jobs failed, because I think that failed test cases could be flaky:
- HARegionCacheListenerARLTest.afterRegionLive
- TransactionCleaningTest.txWithStoppedServer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina edited a comment on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina edited a comment on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-919033963
I put as review ready even though two test jobs failed, because I think that failed test cases could be flaky:
- HARegionCacheListenerARLTest.afterRegionLive (concourse-ci/build-ubuntu-16.04-debug )
- TransactionCleaningTest.txWithStoppedServer (concourse-ci/build-ubuntu-18.04-debug)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-919268407
Can confirm, if any test cases are gonna fail it'll be these two.
Thanks,
Blake
From: Jakov Varenina ***@***.***>
Sent: Tuesday, September 14, 2021 3:45 AM
To: apache/geode-native ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [apache/geode-native] GEODE-9591: Don't retry function when Function.isHA=false (#866)
I put as review ready even thought two test jobs failed, because I think that failed test cases could be flaky:
* HARegionCacheListenerARLTest.afterRegionLive
* TransactionCleaningTest.txWithStoppedServer
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode-native%2Fpull%2F866%23issuecomment-919033963&data=04%7C01%7Cbblake%40vmware.com%7C8cea7c07699b4c8f5fbb08d9776ca8c0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637672130856340826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Qbll0iCPfvDw5IM2etf6ZMIuIU5pUGFI4QrURhGtp00%3D&reserved=0>, or unsubscribe<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAXDUM2YFJMUNU2DKODR2CDUB4RRTANCNFSM5D55LP6Q&data=04%7C01%7Cbblake%40vmware.com%7C8cea7c07699b4c8f5fbb08d9776ca8c0%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637672130856340826%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=J7rED6cI7awzMb5BrenqqZxL96gYmMXSBSiTEG%2Fgyls%3D&reserved=0>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-943093975
@pdxcodemonkey Ok, I will keep eye on it. I have checked `OnServerHAExecuteFunctionTest` test case, and I couldn't find any connection to this PR solution. This PR only impacts function executions that have `Function.isHA` set to `false` (this flag is checked before all impact introduced in this PR), and `OnServerHAExecuteFunctionTest` has this parameter set to `true`. I will execute this failing case and check this in more details. Thank you pointing this out to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-942397899
@jvarenina Just want to mention here, in case it's important going forward: The test `Apache.Geode.Client.UnitTests.ThinClientFunctionExecutionTests.OnServerHAExecuteFunctionTest` has failed on the Server 2019, VS 2019 release build job in CI (https://concourse.apachegeode-ci.info/teams/main/pipelines/geode-native-develop/jobs/build-windows-2019-vs-2019-release/builds/122). It has passed on other Windows jobs (https://concourse.apachegeode-ci.info/teams/main/pipelines/geode-native-develop/jobs/build-windows-2016-vs-2017-release/builds/120 , e.g.), but failed first and then passed on retry. This seems at least plausibly related to this PR, so it's worth keeping an eye on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] jvarenina commented on pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
jvarenina commented on pull request #866:
URL: https://github.com/apache/geode-native/pull/866#issuecomment-940118669
Hi @pdxcodemonkey ,
I just rebased this PR. It seems that flaky tests failed again:` TransactionCleaningTest.txWithStoppedServer (Failed) ( concourse-ci/build-rhel-7-debug )`. I don't see connection between this case and this PR solution.
Also it seems that one of my cases `testThatFunctionExecutionThrowsExceptionNonHAWithFilter` faild this time. I will check what could be the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey merged pull request #866: GEODE-9591: Don't retry function when Function.isHA=false
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey merged pull request #866:
URL: https://github.com/apache/geode-native/pull/866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org