You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by zwoop <gi...@git.apache.org> on 2017/02/15 18:53:00 UTC
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1451
Cleans up ICC options, and some build issues
This removes a number of the previous warning exclusions that we
we used to do. We then also have to clean up the core code in a
few places, sometimes looking slightly odd (e.g. the meaningless
const that we have in a few places).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver ICC
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1451
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101584542
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
Actually, I'm not gonna change this, because everything else (in a million places) uses the C-style cast already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101558075
--- Diff: iocore/eventsystem/P_IOBuffer.h ---
@@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i)
}
ink_release_assert(!"out of range");
+ return default_ret[0];
--- End diff --
Sure, I can try that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1458/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1451/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101527244
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
No C-style casts! `static_cast<void*>(handler)` although we should really rethink using `void*` in this context.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/129/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101558553
--- Diff: lib/ts/signals.cc ---
@@ -46,7 +46,7 @@ signal_check_handler(int signal, signal_handler_t handler)
sigact = (void *)oact.sa_sigaction;
}
- if (sigact != handler) {
+ if (sigact != (void *)handler) {
--- End diff --
I did look / try not using void *, but it turns out the sigaction is not the same type as the handler. So some casting would be needed.
And yeh, I'll change to amc style cast, only because you are the best, and currently sitting in the #1 spot on the ranking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/123/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1451: Cleans up ICC options, and some build issu...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1451#discussion_r101526314
--- Diff: iocore/eventsystem/P_IOBuffer.h ---
@@ -694,6 +695,7 @@ TS_INLINE char &IOBufferReader::operator[](int64_t i)
}
ink_release_assert(!"out of range");
+ return default_ret[0];
--- End diff --
The real problem is ICC doesn't realize the assert never returns.
Although, I don't understand why `static char zwoop = '0';` `return zwoop;` wouldn't work, rather than messing about with an array.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1555/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1449/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1564/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/120/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1451: Cleans up ICC options, and some build issues
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1451
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1558/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---