You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/04/11 19:24:37 UTC
[GitHub] [arrow] izveigor opened a new pull request, #35050: MINOR: [Go] Add "IsSignedInteger"
izveigor opened a new pull request, #35050:
URL: https://github.com/apache/arrow/pull/35050
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Return true, if data type is signed integer(int8, int16, int32, int64).
### What changes are included in this PR?
Implementation "IsSignedInteger"
### Are these changes tested?
No
### Are there any user-facing changes?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35050: MINOR: [Go] Add "IsSignedInteger"
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35050:
URL: https://github.com/apache/arrow/pull/35050#issuecomment-1508076084
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8d5493a61a074fdfa52a0ae7e88913fa...b239bf7c92794ca5ba7d9f1db3c66c6d/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35050: MINOR: [Go] Add "IsSignedInteger"
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35050:
URL: https://github.com/apache/arrow/pull/35050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35050: MINOR: [Go] Add "IsSignedInteger"
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35050:
URL: https://github.com/apache/arrow/pull/35050#issuecomment-1508072075
Benchmark runs are scheduled for baseline = 11ecfd91e3c051761f34b37f1ec88335100bcd57 and contender = 49e60a0d4935acde515bfce9fa5ec18ffd7c2202. 49e60a0d4935acde515bfce9fa5ec18ffd7c2202 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a496040db327459298e954beab2d0f03...b9e2f5a88e5d48758e1fd31687815556/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a0f277bdf8a241d5b541920522aee820...7a823c3d9be54b7184c378b29f65bc62/)
[Finished :arrow_down:1.53% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/8d5493a61a074fdfa52a0ae7e88913fa...b239bf7c92794ca5ba7d9f1db3c66c6d/)
[Finished :arrow_down:0.31% :arrow_up:0.15%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/15d538605bc94c9291c75e125d9c8efe...48a648cf7c824dfa93c3edf9cef250de/)
Buildkite builds:
[Finished] [`49e60a0d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2693)
[Failed] [`49e60a0d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2727)
[Finished] [`49e60a0d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2691)
[Finished] [`49e60a0d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2718)
[Finished] [`11ecfd91` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2692)
[Failed] [`11ecfd91` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2726)
[Finished] [`11ecfd91` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2690)
[Finished] [`11ecfd91` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2717)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org