You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2023/01/10 06:47:02 UTC

[GitHub] [rocketmq] cserwen commented on a diff in pull request #5845: [ISSUE #5838] retry to send when broker returns SYSTEM_BUSY

cserwen commented on code in PR #5845:
URL: https://github.com/apache/rocketmq/pull/5845#discussion_r1065385746


##########
client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java:
##########
@@ -72,7 +72,8 @@ public class DefaultMQProducer extends ClientConfig implements MQProducer {
         ResponseCode.SYSTEM_ERROR,
         ResponseCode.NO_PERMISSION,
         ResponseCode.NO_BUYER_ID,
-        ResponseCode.NOT_IN_CURRENT_UNIT
+        ResponseCode.NOT_IN_CURRENT_UNIT,
+        ResponseCode.SYSTEM_BUSY

Review Comment:
   We don't know the intent of the author who wrote it, so removing it is probably not a good option. Although I also think that client should not retry when broker returns `TOPIC_NOT_EXIST`:smile:. @ShadowySpirits 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org