[GitHub] [airflow] ashb commented on a change in pull request #11396: Add creating_job_id to DagRun table

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #11396:
URL: https://github.com/apache/airflow/pull/11396#discussion_r506289285



##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -1658,6 +1658,9 @@ def _schedule_dag_run(self, dag_run: DagRun, currently_active_runs: int, session
                 )
                 return 0
 
+        # This DagRun will be schedule by this job so we set up the creating_job_id
+        dag_run.creating_job_id = self.id

Review comment:
       I think we should only set this when actually _creating_ the DagRun, not every time we schedule it, so this should be in the `_create_dag_runs` function instead.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org