You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/13 12:13:59 UTC
[GitHub] [hive] aasha opened a new pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
aasha opened a new pull request #1247:
URL: https://github.com/apache/hive/pull/1247
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1247:
URL: https://github.com/apache/hive/pull/1247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1247:
URL: https://github.com/apache/hive/pull/1247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1247:
URL: https://github.com/apache/hive/pull/1247#discussion_r456242103
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcrossInstances.java
##########
@@ -944,96 +944,6 @@ public void testIncrementalDumpMultiIteration() throws Throwable {
Assert.assertEquals(IncrementalLoadTasksBuilder.getNumIteration(), numEvents);
}
- @Test
- public void testIfCkptAndSourceOfReplPropsIgnoredByReplDump() throws Throwable {
Review comment:
This was testing that source of replication properties are ignored by replication while the custom ones are not. Can we retain that part?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java
##########
@@ -219,6 +219,11 @@ private void initReplDump(ASTNode ast) throws HiveException {
" as it is not a source of replication (repl.source.for)");
throw new SemanticException(ErrorMsg.REPL_DATABASE_IS_NOT_SOURCE_OF_REPLICATION.getMsg());
}
+ if (ReplUtils.isTargetOfReplication(database)) {
+ LOG.error("Cannot dump database " + dbNameOrPattern +
+ " as it is a target of replication (repl.target.for)");
Review comment:
nit: Can accommodate in one line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1247:
URL: https://github.com/apache/hive/pull/1247#issuecomment-693103904
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1247: HIVE-23474 : Deny Repl Dump if the database is a target of replication
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1247:
URL: https://github.com/apache/hive/pull/1247#discussion_r456406599
##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcrossInstances.java
##########
@@ -944,96 +944,6 @@ public void testIncrementalDumpMultiIteration() throws Throwable {
Assert.assertEquals(IncrementalLoadTasksBuilder.getNumIteration(), numEvents);
}
- @Test
- public void testIfCkptAndSourceOfReplPropsIgnoredByReplDump() throws Throwable {
Review comment:
Agree, added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org