[GitHub] [flink] echauchot commented on a diff in pull request #19586: [FLINK-26824] Upgrade Flink's supported Cassandra versions to match all Apache Cassandra supported versions

[GitBox <gi...@apache.org>]

echauchot commented on code in PR #19586:
URL: https://github.com/apache/flink/pull/19586#discussion_r859596704


##########
flink-connectors/flink-connector-cassandra/pom.xml:
##########
@@ -37,8 +37,10 @@ under the License.
 
 	<!-- Allow users to pass custom connector versions -->
 	<properties>
-		<cassandra.version>2.2.5</cassandra.version>
-		<driver.version>3.0.0</driver.version>
+		<!-- Cassandra version 4.x allow to address clusters of version 3.x as well -->
+		<cassandra.version>4.0.3</cassandra.version>
+		<!--driver 3.x works with 3.x and 4.x versions of Cassandra but driver 4.x is a complete refactoring with different API-->
+		<driver.version>3.11.1</driver.version>
 		<guava.version>18.0</guava.version>

Review Comment:
   Actually I don't think this explicit dependency was needed in the first place. Indeed cassandra driver 3.0.0 had `com.google.guava:guava:jar:16.0.1:compile` as a transitive dep and our code depends on the shaded guava (`import org.apache.flink.shaded.guava30.com.google.common.base.Strings;`). Removing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org