You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2011/06/26 19:02:21 UTC
svn commit: r1139837 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/
Author: erans
Date: Sun Jun 26 17:02:20 2011
New Revision: 1139837
URL: http://svn.apache.org/viewvc?rev=1139837&view=rev
Log:
MATH-599
Name change to avoid test failure on the automated build system ("gump").
Added:
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverAbstractTest.java
- copied, changed from r1139509, commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverTest.java
Removed:
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverTest.java
Modified:
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/IllinoisSolverTest.java
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/PegasusSolverTest.java
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/RegulaFalsiSolverTest.java
commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/SecantSolverTest.java
Copied: commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverAbstractTest.java (from r1139509, commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverTest.java)
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverAbstractTest.java?p2=commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverAbstractTest.java&p1=commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverTest.java&r1=1139509&r2=1139837&rev=1139837&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/BaseSecantSolverAbstractTest.java Sun Jun 26 17:02:20 2011
@@ -32,7 +32,7 @@ import org.junit.Test;
*
* @version $Id$
*/
-public abstract class BaseSecantSolverTest {
+public abstract class BaseSecantSolverAbstractTest {
/** Returns the solver to use to perform the tests.
* @return the solver to use to perform the tests
*/
@@ -46,11 +46,6 @@ public abstract class BaseSecantSolverTe
*/
protected abstract int[] getQuinticEvalCounts();
- /**
- * Tests can be run only from subclasses.
- */
- protected BaseSecantSolverTest() {}
-
@Test
public void testSinZero() {
// The sinus function is behaved well around the root at pi. The second
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/IllinoisSolverTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/IllinoisSolverTest.java?rev=1139837&r1=1139836&r2=1139837&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/IllinoisSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/IllinoisSolverTest.java Sun Jun 26 17:02:20 2011
@@ -22,7 +22,7 @@ package org.apache.commons.math.analysis
*
* @version $Id$
*/
-public final class IllinoisSolverTest extends BaseSecantSolverTest {
+public final class IllinoisSolverTest extends BaseSecantSolverAbstractTest {
/** {@inheritDoc} */
protected UnivariateRealSolver getSolver() {
return new IllinoisSolver();
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/PegasusSolverTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/PegasusSolverTest.java?rev=1139837&r1=1139836&r2=1139837&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/PegasusSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/PegasusSolverTest.java Sun Jun 26 17:02:20 2011
@@ -22,7 +22,7 @@ package org.apache.commons.math.analysis
*
* @version $Id$
*/
-public final class PegasusSolverTest extends BaseSecantSolverTest {
+public final class PegasusSolverTest extends BaseSecantSolverAbstractTest {
/** {@inheritDoc} */
protected UnivariateRealSolver getSolver() {
return new PegasusSolver();
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/RegulaFalsiSolverTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/RegulaFalsiSolverTest.java?rev=1139837&r1=1139836&r2=1139837&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/RegulaFalsiSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/RegulaFalsiSolverTest.java Sun Jun 26 17:02:20 2011
@@ -22,7 +22,7 @@ package org.apache.commons.math.analysis
*
* @version $Id$
*/
-public final class RegulaFalsiSolverTest extends BaseSecantSolverTest {
+public final class RegulaFalsiSolverTest extends BaseSecantSolverAbstractTest {
/** {@inheritDoc} */
protected UnivariateRealSolver getSolver() {
return new RegulaFalsiSolver();
Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/SecantSolverTest.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/SecantSolverTest.java?rev=1139837&r1=1139836&r2=1139837&view=diff
==============================================================================
--- commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/SecantSolverTest.java (original)
+++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/SecantSolverTest.java Sun Jun 26 17:02:20 2011
@@ -22,7 +22,7 @@ package org.apache.commons.math.analysis
*
* @version $Id$
*/
-public final class SecantSolverTest extends BaseSecantSolverTest {
+public final class SecantSolverTest extends BaseSecantSolverAbstractTest {
/** {@inheritDoc} */
protected UnivariateRealSolver getSolver() {
return new SecantSolver();
Re: svn commit: r1139837 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/
Posted by sebb <se...@gmail.com>.
On 27 June 2011 22:31, sebb <se...@gmail.com> wrote:
> On 27 June 2011 11:13, Gilles Sadowski <gi...@harfang.homelinux.org> wrote:
>> On Mon, Jun 27, 2011 at 12:16:05AM +0100, sebb wrote:
>>> On 26 June 2011 18:02, <er...@apache.org> wrote:
>>> > Author: erans
>>> > Date: Sun Jun 26 17:02:20 2011
>>> > New Revision: 1139837
>>> >
>>> > URL: http://svn.apache.org/viewvc?rev=1139837&view=rev
>>> > Log:
>>> > MATH-599
>>> > Name change to avoid test failure on the automated build system ("gump").
>>>
>>> Actually, the failure is nothing to do with Gump per se.
>>> The test fails with Ant, because JUnit does not like abstract files.
>>
>> This why the test failed. But the reason for the change was that two
>> standard tool suites ("maven" vs "gump") did not provide the same result.
>> Of course I didn't mean that there was a bug in "gump", but that gump
>> reported failure while maven did not.
>
> You might as well say that Continuum did not report failure, but Gump did.
>
> Gump can use either Ant or Maven, so the message is misleading.
Also, the fix works for stand-alone Ant, which is more to the point.
>
>>
>> Gilles
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1139837 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/
Posted by sebb <se...@gmail.com>.
On 27 June 2011 11:13, Gilles Sadowski <gi...@harfang.homelinux.org> wrote:
> On Mon, Jun 27, 2011 at 12:16:05AM +0100, sebb wrote:
>> On 26 June 2011 18:02, <er...@apache.org> wrote:
>> > Author: erans
>> > Date: Sun Jun 26 17:02:20 2011
>> > New Revision: 1139837
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1139837&view=rev
>> > Log:
>> > MATH-599
>> > Name change to avoid test failure on the automated build system ("gump").
>>
>> Actually, the failure is nothing to do with Gump per se.
>> The test fails with Ant, because JUnit does not like abstract files.
>
> This why the test failed. But the reason for the change was that two
> standard tool suites ("maven" vs "gump") did not provide the same result.
> Of course I didn't mean that there was a bug in "gump", but that gump
> reported failure while maven did not.
You might as well say that Continuum did not report failure, but Gump did.
Gump can use either Ant or Maven, so the message is misleading.
>
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1139837 -
/commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/
Posted by Gilles Sadowski <gi...@harfang.homelinux.org>.
On Mon, Jun 27, 2011 at 12:16:05AM +0100, sebb wrote:
> On 26 June 2011 18:02, <er...@apache.org> wrote:
> > Author: erans
> > Date: Sun Jun 26 17:02:20 2011
> > New Revision: 1139837
> >
> > URL: http://svn.apache.org/viewvc?rev=1139837&view=rev
> > Log:
> > MATH-599
> > Name change to avoid test failure on the automated build system ("gump").
>
> Actually, the failure is nothing to do with Gump per se.
> The test fails with Ant, because JUnit does not like abstract files.
This why the test failed. But the reason for the change was that two
standard tool suites ("maven" vs "gump") did not provide the same result.
Of course I didn't mean that there was a bug in "gump", but that gump
reported failure while maven did not.
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1139837 - /commons/proper/math/trunk/src/test/java/org/apache/commons/math/analysis/solvers/
Posted by sebb <se...@gmail.com>.
On 26 June 2011 18:02, <er...@apache.org> wrote:
> Author: erans
> Date: Sun Jun 26 17:02:20 2011
> New Revision: 1139837
>
> URL: http://svn.apache.org/viewvc?rev=1139837&view=rev
> Log:
> MATH-599
> Name change to avoid test failure on the automated build system ("gump").
Actually, the failure is nothing to do with Gump per se.
The test fails with Ant, because JUnit does not like abstract files.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org